-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul build system for modern Python and enable cibuildwheel #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 09e24a2.
…nda-forge-pinning 2025.01.15.19.32.56
They in fact will not match in a Windows conda build, so instead we can just warn to alert the user that something might be wrong but allow it to proceed if that's really what's intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move to scikit-build-core and pyproject.toml for building/packaging the Python package, and add a cibuildwheel action to build Python wheels based on the new build system. This attempts to follow recommended practice from the Scientific Python Library Development Guide and Cookiecutter. Eventually that will mean enabling more pre-commit hooks and formatting/linting with ruff instead of flake8/black, but I haven't gone through that full transition yet.
Also fixes #63.