Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong rotation function parameters correction. #88

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

zyuanbing
Copy link
Contributor

Thanks for the release.
I followed the instructions to compile the code, and try to reproduce the GIF showed in profile. When I ran

python teaser_python_3dsmooth.py

there was a bug:

TypeError: rotate(): incompatible function arguments. The following argument types are supported:
    1. (self: open3d.open3d_pybind.geometry.Geometry3D, R: numpy.ndarray[float64[3, 3]], center: numpy.ndarray[float64[3, 1]]) -> open3d.open3d_pybind.geometry.Geometry3D

Invoked with: geometry::TriangleMesh with 102 points and 200 triangles., array([[ 0.99154181, -0.09292577, -0.09060704],
       [-0.09292577, -0.02092779, -0.99545308],
       [ 0.09060704,  0.99545308, -0.02938598]]); kwargs: center=True

It might be wrong parameter. Perhaps it should be coordinate origin (0, 0, 0). I'm not very sure if correcting it this way would cause a new problem, but it works for me, maybe try it.

Incompatible function arguments. The following argument types are supported:
    1. (self: open3d.open3d_pybind.geometry.Geometry3D, R: numpy.ndarray[float64[3, 3]], center: numpy.ndarray[float64[3, 1]]) -> open3d.open3d_pybind.geometry.Geometry3D

Invoked with: geometry::TriangleMesh with 102 points and 200 triangles., array([[ 0.99154181, -0.09292577, -0.09060704],
       [-0.09292577, -0.02092779, -0.99545308],
       [ 0.09060704,  0.99545308, -0.02938598]]); kwargs: center=True

Wrong center parameter. It should be coordinate origin (0, 0, 0).
@jingnanshi
Copy link
Member

jingnanshi commented Mar 9, 2021

@zyuanbing Thanks!

It looks like this is due to Open3D changing their function signature after updating to 0.12.

@jingnanshi jingnanshi merged commit 5949089 into MIT-SPARK:master Mar 9, 2021
@tpwrules
Copy link

This causes issue #99 with Open3D 0.9. If you revert this commit then everything works.

@jingnanshi
Copy link
Member

@tpwrules Thanks for the feedback. I will add an explicit comment saying that Open3D 0.9 will have issue with this example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants