Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add viscous and surface_tension logicals #688

Merged
merged 12 commits into from
Nov 7, 2024

Conversation

wilfonba
Copy link
Contributor

@wilfonba wilfonba commented Nov 5, 2024

Description

Add surface_tension and viscous logicals.

Fixes #677 , #668

Type of change

Please delete options that are not relevant.

  • Something else

Scope

  • This PR comprises a set of related changes with a common goal

How Has This Been Tested?

Built and ran test suite locally on CPUs and on Frontier with GPUs.

@wilfonba wilfonba requested a review from sbryngelson as a code owner November 5, 2024 17:25
@sbryngelson sbryngelson linked an issue Nov 5, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 120 lines in your changes missing coverage. Please review.

Project coverage is 43.04%. Comparing base (d97c878) to head (cb49a24).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/simulation/m_riemann_solvers.fpp 8.92% 1 Missing and 50 partials ⚠️
src/simulation/m_rhs.fpp 28.88% 13 Missing and 19 partials ⚠️
src/simulation/m_viscous.fpp 0.00% 0 Missing and 10 partials ⚠️
src/simulation/m_sim_helpers.f90 0.00% 0 Missing and 6 partials ⚠️
src/common/m_variables_conversion.fpp 0.00% 1 Missing and 4 partials ⚠️
src/simulation/m_global_parameters.fpp 50.00% 0 Missing and 4 partials ⚠️
src/post_process/m_global_parameters.fpp 33.33% 0 Missing and 2 partials ⚠️
src/pre_process/m_global_parameters.fpp 33.33% 0 Missing and 2 partials ⚠️
src/simulation/m_data_output.fpp 66.66% 0 Missing and 2 partials ⚠️
src/simulation/m_mpi_proxy.fpp 0.00% 0 Missing and 2 partials ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #688      +/-   ##
==========================================
+ Coverage   42.99%   43.04%   +0.05%     
==========================================
  Files          61       61              
  Lines       16053    16062       +9     
  Branches     1796     1798       +2     
==========================================
+ Hits         6902     6914      +12     
+ Misses       8167     8158       -9     
- Partials      984      990       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbryngelson
Copy link
Member

needs checkers:

  • if viscous and Re(1 or 2) == dflt_real -> stop
  • if Re(1 or 2) > 0 and not viscous -> stop
  • if surface_tension and sigma == dflt -> stop
  • if sigma == dflt and not surface_tension -> stop

Also every example that uses viscosity or surface tension needs these logical variables added to their case.py file

@sbryngelson sbryngelson merged commit f45888f into MFlowCode:master Nov 7, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add viscous flag instead of any(Re_size > 0) Add a surface_tension boolean input parameter
2 participants