-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new emulation integration tests #599
Add new emulation integration tests #599
Conversation
4587fa8
to
d5ad611
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
+ Coverage 80.18% 80.32% +0.14%
==========================================
Files 49 49
Lines 3068 3070 +2
==========================================
+ Hits 2460 2466 +6
+ Misses 608 604 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super! Yes agree to deprecate the rest - I am not sure what the best approach is, though - maybe a decorator?
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
for more information, see https://pre-commit.ci
Hm as far as is see the decorator needs a new dependency? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
I added emulation tests for the new code path also using
DataTree
. I added also tests to draw realizations for several forcing scenarios at once, which is new compared to the old tests. What is also new is that I actually use scenario data as forcing data while the old tests used dummy data. There is no real advantage of that I think, I just liked the idea of the test being consistent with the verification process. Note that when I draw realizations for ssp585 and ssp126 I also use the parameter set that was calibrated on those two scenarios which is not really necessary. However, this implicitly tests that all parameter sets we created lead to stable emulations.CHANGELOG.rst