Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new emulation integration tests #599

Merged

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi commented Jan 23, 2025

I added emulation tests for the new code path also using DataTree. I added also tests to draw realizations for several forcing scenarios at once, which is new compared to the old tests. What is also new is that I actually use scenario data as forcing data while the old tests used dummy data. There is no real advantage of that I think, I just liked the idea of the test being consistent with the verification process. Note that when I draw realizations for ssp585 and ssp126 I also use the parameter set that was calibrated on those two scenarios which is not really necessary. However, this implicitly tests that all parameter sets we created lead to stable emulations.

  • Fully documented, including CHANGELOG.rst

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi changed the title Integration drawing tests Add new emulation integration tests Jan 24, 2025
@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Okay this would maybe be a good time for #262 respectively #276. If we deprecate the old functions, could we remove the tests without loosing coverage @mathause? It would be nice we could delete the bundle and the old emulation output files from the repo to save some space.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.32%. Comparing base (75d18fe) to head (2352eb3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   80.18%   80.32%   +0.14%     
==========================================
  Files          49       49              
  Lines        3068     3070       +2     
==========================================
+ Hits         2460     2466       +6     
+ Misses        608      604       -4     
Flag Coverage Δ
unittests 80.32% <ø> (+0.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super! Yes agree to deprecate the rest - I am not sure what the best approach is, though - maybe a decorator?

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Yes agree to deprecate the rest - I am not sure what the best approach is, though - maybe a decorator?

Hm as far as is see the decorator needs a new dependency?

Copy link
Member

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi merged commit 32a5eb0 into MESMER-group:main Jan 28, 2025
11 checks passed
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi deleted the draw_test branch January 28, 2025 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants