-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expression
: split out evaluate_params
#539
Expression
: split out evaluate_params
#539
Conversation
Expression
split out evaluate_params
Expression
: split out evaluate_params
Expression
: split out evaluate_params
Expression
: split out evaluate_params
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #539 +/- ##
==========================================
+ Coverage 61.89% 61.93% +0.03%
==========================================
Files 50 50
Lines 3551 3554 +3
==========================================
+ Hits 2198 2201 +3
Misses 1353 1353
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
4d8013d
to
714ddc0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Co-authored-by: Victoria <112418493+veni-vidi-vici-dormivi@users.noreply.github.com>
@l-pierini with this change merged you should see a performance improvement for the fitting (more to come but I don't know when) |
CHANGELOG.rst
This creates a separate method to
evaluate_params
- so we don't necessarily create the frozen distribution. E.g. if we only needparams["loc"]
we can save the slow creation of the distribution.This saves about 1-2 minutes on the tests already (about 20% - 25%).
Only a draft PR for now
Expression.evaluate
: avoidexec
by usinglocals
#535 - so waiting for that to be merged first