-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mesmer_m example script #491
add mesmer_m example script #491
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #491 +/- ##
=======================================
Coverage 50.32% 50.32%
=======================================
Files 50 50
Lines 3527 3527
=======================================
Hits 1775 1775
Misses 1752 1752
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - the mesmer-m approach is now really concise and well readable. I am happy to merge as a script but I would eventually like to create notebooks that we can include in our documentation (ah but it's still 40s (on my laptop) which is long to run for a doc build).
- do you know if Shruti ever fits more than one ensemble member and/ or scenario? Because this may not be possible in the current form 😬
- would also be good to have an integration test from this script (but again the 40 s is very long for this)
I quickly timed the individual parts (to have a reference)
|
Thank you, I think so too, we did a good job 😊
Hm yeah a notebook for the docs would be really cool. I would merge as is now and pretty it up later when we are done with the numerical issues.
I thought about that already and in the paper she writes that she uses only one scenario. If there are several members she splits them into a training and a test set and for some there are several members in the test set. I could not infer from the paper if the model is trained on several members together or for each member individually. The notebook provided for the paper definitely has no functionality to handle several members so the aggregation happened either before that or training happened separately and the evaluation statistics were then aggregated. We should ask her about it.
Hm we could try and do it with less years maybe. Interesting that the transformer is the slowest part, good to know. And cool to see that the emulation is very quick, that's nice. |
Okay I switched to a notebook now. It has lots of room for more commenting and some visualisations but we can do that later. |
Thanks. Can you add two more titles: "Calibrate model", and "Find localized empirical covariance" and remove the inputs ("Clear all inputs") |
I will add some more comments to the notebook - I will update it directly, so please don't do the same ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - I approve but maybe you can read through quickly as well.
Through what? |
😮 oh I forgot to push my changes |
Ah no I pushed to -git push origin HEAD
+git push vici HEAD |
* date_range: update freq string * add freq conditionals
for more information, see https://pre-commit.ci
I added some small details and some more info on the time coordinate, that we save. Actually that's only necessary when you want/need the time coordinate on the emulations to be the same as for the data but if that is not necessary one could also create one oneself. |
Thanks! |
* add mesmer_m example script * changelog * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused imports * adjustments * replace script with notebook * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * restructure and add some headings * remove inputs * add some comments * typos * date_range: update freq string (MESMER-group#504) * date_range: update freq string * add freq conditionals * reference: only year as link (MESMER-group#505) * nits * more info on time coordinate * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update comment & clear output --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <mathias.hauser@env.ethz.ch> Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Here an example script that executes the mesmer_m workflow for the coarse test dataset.