-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove power transformer class #474
Remove power transformer class #474
Conversation
for more information, see https://pre-commit.ci
I now deleted the PowerTransformerVariableLambda class. Should we instead deprecate it properly? I thought it is unnecessary because because it was never properly implemented. What do you think @mathause? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
===========================================
- Coverage 87.90% 51.53% -36.38%
===========================================
Files 40 50 +10
Lines 1745 3252 +1507
===========================================
+ Hits 1534 1676 +142
- Misses 211 1576 +1365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good for me to just remove it. It also disentangles it as the PoerTransformer
can also do a box-cox transformation which was however not adapted for variable
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
I think the only point where we still need sklearn now is the tests. So do I see that correctly that we could now (again) have a separate environment for testing and for the users and exclude sklearn in the users environment, or not? Even if so, I would keep it at one environment at this point I think. |
It's always nice to have less dependencies but we can keep it for the moment. Maybe add a comment in setup.cfg? |
CHANGELOG.rst
In this PR I am removing the power transformer class in favor of the newly written xarray functions and adjusting the tests accordingly.