Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MESMER-X: decorator to supress warnings #467

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

mathause
Copy link
Member

Created a decorator to suppress the warnings. This allows to avoid a level of indentation, unfortunately there is not much that is unwrapped. But should become slightly easier to read anyway. We absolutely need to be more specific which warnings we suppress, because currently we also miss deprecations and other warnings we want to see - but have to defer that until we have some running tests to see what warnings there are. github does not seem to get the correct diff...

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 50 lines in your changes missing coverage. Please review.

Project coverage is 51.74%. Comparing base (9b0b76b) to head (df160c4).
Report is 97 commits behind head on main.

Files with missing lines Patch % Lines
mesmer/mesmer_x/train_l_distrib_mesmerx.py 0.00% 50 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #467       +/-   ##
===========================================
- Coverage   87.90%   51.74%   -36.16%     
===========================================
  Files          40       50       +10     
  Lines        1745     3231     +1486     
===========================================
+ Hits         1534     1672      +138     
- Misses        211     1559     +1348     
Flag Coverage Δ
unittests 51.74% <0.00%> (-36.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause
Copy link
Member Author

The diff works better if whitespace differences are ignored

image

merging

@mathause mathause merged commit f0bddc4 into MESMER-group:main Jun 14, 2024
9 checks passed
@mathause mathause deleted the mx_supress_warnings_decorator branch June 14, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant