Add MESMER_M Changelog entries #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #463 +/- ##
===========================================
- Coverage 87.90% 51.53% -36.38%
===========================================
Files 40 50 +10
Lines 1745 3252 +1507
===========================================
+ Hits 1534 1676 +142
- Misses 211 1576 +1365
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks for pulling all of that together!
|
mathause
reviewed
Jul 1, 2024
There was a problem hiding this comment.
I quickly read through it and I think it could be a bit more informative for the breaking changes. Maybe you can structure a bit more by power transformer & power transformer as done in https://github.com/MESMER-group/mesmer/blob/main/CHANGELOG.rst#new-features-2. You don't need to separate all of the PRs but maybe the ones that change functionality.
|
I've taken the liberty to restructure the changelog entries - can you take a look? Do you remember the PR where you fixed the month indices? Must have been one of the first ones... |
|
Yes it was this one: #415, but there was also quite some other stuff going on in that one as well... |
mathause
reviewed
Jul 12, 2024
mathause
approved these changes
Jul 19, 2024
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
veni-vidi-vici-dormivi
added a commit
to veni-vidi-vici-dormivi/mesmer
that referenced
this pull request
Jul 22, 2024
* add MESMER_M Changelog entries --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <mathias.hauser@env.ethz.ch> Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
veni-vidi-vici-dormivi
added a commit
that referenced
this pull request
Jul 27, 2024
* implement generation of harmonic model time series in xarray needed for emulation * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update mesmer/mesmer_m/harmonic_model.py Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * renaming * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Add MESMER_M Changelog entries (#463) * add MESMER_M Changelog entries --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <mathias.hauser@env.ethz.ch> Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * changelog * add monthly AR1 process utilities (#473) * add monthly AR1 process utilities * add tests * add new functions to stats init * reshape AR output dims from year, month to time * new drawing method and change in predict function * add test for drawing * remove buffer as multiple of 12 * extract drawing innovations * comments and nits * start autoregression at one * allow covariance none * adjust tests * changelog * documentation * fixes * make args in draw_autoregression_monthly keyword only --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> * Revert "add monthly AR1 process utilities (#473)" This reverts commit 5dd4292. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com> Co-authored-by: Mathias Hauser <mathias.hauser@env.ethz.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the Changelog entries for the MESMER-M work of the past few weeks