Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Harmonic model return residuals #460

Merged
merged 9 commits into from
May 31, 2024

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi commented May 29, 2024

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.79%. Comparing base (9b0b76b) to head (b9efe99).
Report is 90 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #460      +/-   ##
==========================================
+ Coverage   87.90%   88.79%   +0.88%     
==========================================
  Files          40       43       +3     
  Lines        1745     1883     +138     
==========================================
+ Hits         1534     1672     +138     
  Misses        211      211              
Flag Coverage Δ
unittests 88.79% <100.00%> (+0.88%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if the tests are faster because they abort earlier or because the fitting is genuinely faster?

@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Do you know if the tests are faster because they abort earlier or because the fitting is genuinely faster?

Should be because they are generally faster because also before they aborted at low orders (for few time steps).

@mathause
Copy link
Member

Yes you are right it seems to be both 🍾

@mathause
Copy link
Member

This brings down the time of the tests by 30 s (1/3) - another nice win 🥇

@mathause mathause merged commit cf8087d into MESMER-group:main May 31, 2024
9 checks passed
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi deleted the hm_tests branch May 31, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harmonic model testing
2 participants