-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Harmonic model return residuals #460
Conversation
veni-vidi-vici-dormivi
commented
May 29, 2024
•
edited
Loading
edited
- Closes Harmonic model testing #459
- Tests added
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #460 +/- ##
==========================================
+ Coverage 87.90% 88.79% +0.88%
==========================================
Files 40 43 +3
Lines 1745 1883 +138
==========================================
+ Hits 1534 1672 +138
Misses 211 211
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know if the tests are faster because they abort earlier or because the fitting is genuinely faster?
Should be because they are generally faster because also before they aborted at low orders (for few time steps). |
Yes you are right it seems to be both 🍾 |
for more information, see https://pre-commit.ci
This brings down the time of the tests by 30 s (1/3) - another nice win 🥇 |