rename i and j in power transformer transform & inverse transform #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about yet another PR but I had to do this before I forget about it. |
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #444 +/- ##
==========================================
- Coverage 87.90% 81.94% -5.96%
==========================================
Files 40 44 +4
Lines 1745 1939 +194
==========================================
+ Hits 1534 1589 +55
- Misses 211 350 +139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mathause
approved these changes
May 13, 2024
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
veni-vidi-vici-dormivi
added a commit
to veni-vidi-vici-dormivi/mesmer
that referenced
this pull request
May 23, 2024
…SMER-group#444) * rename i and j to gridcell and year for readability and some commentary --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renamed i and j indexes to gridcell and year for better readability in
PowerTransformerVariableLambda.transform()andinverse_transform.