Add tests for Power Transformer

[veni-vidi-vici-dormivi]

No description provided.

[veni-vidi-vici-dormivi]

So these fail because the bounds and first guess are not good. Hopefully, after merging #429 and #427 in here, the tests pass. They do locally with the new bounds and fg.

[veni-vidi-vici-dormivi]

Hm why are we not getting a codecov report here?

[mathause]

Hm why are we not getting a codecov report here?

The log gives a hint: https://github.com/MESMER-group/mesmer/pull/430/checks#step:8:55

Can't say that I understand it, though 🤭. I thought codecov was moving away from tokens, but they seem to recommend it again. Let me check what xarray does... Also why only this PR and why consistently?

[mathause]

Ah I think it's here: https://docs.codecov.com/docs/codecov-uploader#supporting-token-less-uploads-for-forks-of-open-source-repos-using-codecov (the last paragraph)

[mathause]

I had a look from my smartphone...

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.79%. Comparing base (9b0b76b) to head (c21905f).
Report is 85 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
- Coverage   87.90%   86.79%   -1.12%     
==========================================
  Files          40       44       +4     
  Lines        1745     1954     +209     
==========================================
+ Hits         1534     1696     +162     
- Misses        211      258      +47     

Flag	Coverage Δ
unittests	86.79% <ø> (-1.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[veni-vidi-vici-dormivi]

Ah now also the Codecov report's here :)

[veni-vidi-vici-dormivi]

We could add another test, but it is not really code related but rather of scientific nature: transform skewed data and test if it is actually less skewed afterwards. What do you think @mathause ?

[mathause]

Ok I add some more suggestions after I understand it a bit better. However, this whole thing is a quite a mess (not your PR - the thing overall). I'll need another pass once we cleaned this up some more and we start to see through.

[mathause]

You ignored some two of my comments, which I think are still valid.

[veni-vidi-vici-dormivi]

You ignored two of my comments, which I think are still valid.

Sorry, hadn't pushed them yet.

[veni-vidi-vici-dormivi]

Okay this got messy but now it's ready to merge.

[mathause]

Nice! Thanks.