-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old_names argument #405
Remove old_names argument #405
Conversation
Note to self: we don't need any depreciation wrangling here because the old_names argument is only used internally, never exposed to the user. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 87.90% 87.97% +0.07%
==========================================
Files 40 40
Lines 1745 1747 +2
==========================================
+ Hits 1534 1537 +3
+ Misses 211 210 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Do we want a CHANGELOG entry for things like this @mathause, given it is an exclusively internal change. Or maybe is it common to have a CHANGELOG entry saying internal adjustments to dependency changes in PRs a b and c... ? |
We don't need a changelog entry for every PR & I decide on a case by case basis; for strictly internal changes I often don't add one. Here I'd add statsmodels to the list of "supported versions". Can you add the statsmodels pin to setup.cfg? |
b.t.w. its deprecation (only one i) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to add the PR number above the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
old_names
argument #396CHANGELOG.rst