Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove ensemble anomaly type 'first' #247

Merged
merged 2 commits into from
Jan 22, 2023

Conversation

mathause
Copy link
Member

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

This removes ref["type"] == "first" i.e., caculating the anomaly w.r.t. the first ensemble member. Also adds more tests to the data loading and cleans the code/ comments a bit.

@codecov-commenter
Copy link

codecov-commenter commented Jan 22, 2023

Codecov Report

Base: 86.73% // Head: 86.86% // Increases project coverage by +0.13% 🎉

Coverage data is based on head (4ec66ea) compared to base (f5b36fb).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   86.73%   86.86%   +0.13%     
==========================================
  Files          38       38              
  Lines        1530     1530              
==========================================
+ Hits         1327     1329       +2     
+ Misses        203      201       -2     
Flag Coverage Δ
unittests 86.86% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mesmer/io/_load_cmipng.py 80.76% <100.00%> (+1.53%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mathause mathause merged commit f158f94 into MESMER-group:main Jan 22, 2023
@mathause mathause deleted the remove_type_first branch March 31, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants