-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xarray_utils: calculate global mean #220
Conversation
Codecov ReportBase: 85.03% // Head: 85.13% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #220 +/- ##
==========================================
+ Coverage 85.03% 85.13% +0.10%
==========================================
Files 35 36 +1
Lines 1483 1507 +24
==========================================
+ Hits 1261 1283 +22
- Misses 222 224 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@znicholls: as always a quick look and your opinion on naming is appreciated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, minor comments.
Should be easy enough to extend to using model reported grid cell areas, should we ever go down that path...
docs/source/api.rst
Outdated
.. autosummary:: | ||
:toctree: generated/ | ||
|
||
~xarray_utils.globmean.lat_weights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~xarray_utils.globmean.lat_weights | |
~xarray_utils.global_mean.lat_weights |
I'd be tempted to just write it out, but doesn't really matter
Co-authored-by: Zeb Nicholls <zebedee.nicholls@climate-energy-college.org>
isort . && black . && flake8
CHANGELOG.rst
Next data handling PR: calculating weighted global means.