Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use LinearRegression in train_gt_ic_OLSVOLC #145

Merged
merged 3 commits into from
May 30, 2022

Conversation

mathause
Copy link
Member

After #144 we can now use mesmer.core.linear_regression.LinearRegression in train_gt_ic_OLSVOLC.

  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

@codecov-commenter
Copy link

codecov-commenter commented May 25, 2022

Codecov Report

Merging #145 (b953704) into master (5944564) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
- Coverage   79.25%   79.19%   -0.06%     
==========================================
  Files          30       30              
  Lines        1393     1389       -4     
==========================================
- Hits         1104     1100       -4     
  Misses        289      289              
Flag Coverage Δ
unittests 79.19% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mesmer/calibrate_mesmer/train_gt.py 81.60% <100.00%> (ø)
mesmer/io/load_obs.py 27.08% <100.00%> (-5.61%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5944564...b953704. Read the comment docs.

@mathause mathause requested a review from znicholls May 25, 2022 17:57
Copy link
Collaborator

@znicholls znicholls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Co-authored-by: Zeb Nicholls <zebedee.nicholls@climate-energy-college.org>
@mathause mathause merged commit 3892e76 into MESMER-group:master May 30, 2022
@mathause mathause deleted the train_gt_ic_OLSVOLC_use_xr branch May 30, 2022 07:01
@mathause
Copy link
Member Author

Thanks for the review!

@mathause mathause mentioned this pull request Jun 10, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants