Rename linear regression functions #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I decided to split #141 into 2 PRs. This PR needs to be merged first and it
linear_regressionto_fit_linear_regression_xr_linear_regressionto_fit_linear_regression_npwhich restores consistency with the names of these functions in
auto_regression. This is not super important and I am also not 100% the names are final, but it's more explicit.It also fixes
_fit_linear_regression_xrwhen the target hasnocoordinates.@znicholls this is mostly FYI - no need to review it unless you disagree with the naming of the functions.