-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linear regression: add xarray wrapper #123
Conversation
Codecov Report
@@ Coverage Diff @@
## master #123 +/- ##
==========================================
+ Coverage 78.61% 79.16% +0.54%
==========================================
Files 27 28 +1
Lines 1300 1339 +39
==========================================
+ Hits 1022 1060 +38
- Misses 278 279 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
I am not super happy with this because:
class LinearRegression:don't really like
def fit(predictors, target, dim, weights):
pass
def predict(predictors, dim):
pass
def residuals():
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I am merging this & move the |
isort . && black . && flake8
CHANGELOG.rst