-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix config files #34
Comments
Currently a config state is passed as a param to each function. Also there is no default configuration (or is there?). Can we avoid
Of course the difficult part is to decide which info should be part of the config and what is passed as arguments. copied this comment from #112 to avoid having a duplicate issue |
Some 'config values' I started using.
|
Why having "x_coords" and "x_dim"? Is it called differently in RCMs? And instead of "cell", why not gridcell? A little longer, but more explicit? |
Yes, the coords can be different from the dimensions. rasm = xr.tutorial.open_dataset("rasm")
No super strong opinion - we leaned towards |
Indeed, I remember about the differences between coordinates and dimensions :) But I was rather wondering why this mention to RCMs here? Is it different for them? I would have expected that it would have been the same for RCMs and ESMs? Yes, |
Yes RCMs are usually on a rotated grid. |
The config files are currently raw Python files. We should find a better way to do this.
The text was updated successfully, but these errors were encountered: