Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config files #34

Open
znicholls opened this issue May 6, 2021 · 6 comments
Open

Fix config files #34

znicholls opened this issue May 6, 2021 · 6 comments
Labels
enhancement New feature or request topic-io Input/output questions
Milestone

Comments

@znicholls
Copy link
Collaborator

The config files are currently raw Python files. We should find a better way to do this.

@znicholls znicholls added enhancement New feature or request topic-io Input/output questions labels May 6, 2021
@mathause
Copy link
Member

mathause commented Nov 3, 2021

Currently a config state is passed as a param to each function. Also there is no default configuration (or is there?). Can we avoid cfg entirely? If not here are some projects where we could get inspiration from:

Of course the difficult part is to decide which info should be part of the config and what is passed as arguments.


copied this comment from #112 to avoid having a duplicate issue

@mathause
Copy link
Member

mathause commented Dec 6, 2021

Some 'config values' I started using.

x_dim="lon"
y_dim="lat"
x_coords=None # -> x_dim (important for RCMs)
y_coords=None # -> y_dim (important for RCMs)
cell_dim="cell"
time_dim="time"

@yquilcaille
Copy link
Collaborator

Why having "x_coords" and "x_dim"? Is it called differently in RCMs?

And instead of "cell", why not gridcell? A little longer, but more explicit?

@mathause
Copy link
Member

Why having "x_coords" and "x_dim"? Is it called differently in RCMs?

Yes, the coords can be different from the dimensions.

rasm = xr.tutorial.open_dataset("rasm")

x and y are the dims and xc and yc are the coords

And instead of "cell", why not gridcell? A little longer, but more explicit?

No super strong opinion - we leaned towards cell in #105 but I am happy to reconsider.

@yquilcaille
Copy link
Collaborator

Indeed, I remember about the differences between coordinates and dimensions :) But I was rather wondering why this mention to RCMs here? Is it different for them? I would have expected that it would have been the same for RCMs and ESMs?

Yes, gp and cell were mentionned, but you were saying it is not a good name. Hence gridcell, but i suppose others may have new ideas?

@mathause
Copy link
Member

Yes RCMs are usually on a rotated grid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request topic-io Input/output questions
Projects
None yet
Development

No branches or pull requests

3 participants