-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unstructured grid #105
Comments
This is based on a discussion @mathause & I had last week (obviously very much driven by Mathias' actual knowledge on these things and me learning about them ;)) -> @znicholls maybe it would make sense for you to have a quick look at it before our meeting tomorrow? Especially the part about avoiding
I can live with
@mathause, I remember we talked about
Usually, we'd put |
Avoiding multiindex is totally fine for me, I was literally just hacking anything together which would sort of work but I am glad we now have an actual xarray expert.
I'm happy with whatever. I have always preferred longer names (so gridpoint rather than gp) because I find myself being like, "wtf is gp" for too long at the start of doing work and the extra characters are free. Given that, perhaps cell is better because it's shorter but not an abbreviation (but I really have no preference).
Realisation (and if you want to use american spelling I will live) makes more sense to me too (given I think of emulations leading to realisations or draws), member is also totally fine though given CMIP always takes about members and member_id.
I would make it a more explicit name e.g. "gridpoint_correlation_matrix". I know it starts to get long but I would have no idea what the difference between "gp" and "gp_i" was without stopping and thinking whereas "gridpoint" and "gridpoint_correlation_matrix" are immediately obvious to me (and given we use black the code will never look that horrendous anyway). "gridpoint_crossterms" would also work if we want a more general thing. |
I agree, it would bring more problems over the long term than it would solve now.
I have a small preferences for cell, for the same reasons that @znicholls mentions. "gp" is not very clear, not very user-friendly, and cell is shorter than gridpoint.
I have a preference for member. We are using the runs from ESMs on scenarios under different ensemble members. It is the term used in the climate community, then it would make more sense from my perspective. Plus, it is shorter than realization :) |
Just to follow up on this one more time: seems you all do have nice arguments for
Funny that this is coming up already again (@mathause & I had a moderately important discussion about American vs British English in the context of a comma a few weeks ago). I think we may actually have to make a decision on the type of English we use sometimes soonish. ^^ & more importantly, on the |
Yes, I am not always consistent in my choice of dialect. I did just go check the cmip6 definitions (see note 8). The whole thing is the
but we don't have to adapt this nomenclature. E.g. we generally want to pool everything that is below the level of "model" (but see also #113). |
This issue is relevant for #65
Internally mesmer uses an unstructured grid. That is the lat and lon coords are not 2D but along a vector. When we start using xarray internally we need to name the non-coordinate dimension of the vector. @leabeusch suggests to use
"gp"
(for gridpoint). The most likely alternative would be"cell"
(see details).This is what some other models do:
cell
nCells
ncol
column
andgridcell
ncells
Example:
and the repr would look like
Note: I would not go for a
MultiIndex
because (i) it brings its own set of problems (ii) it should no longer be necessary after the index refactor of xarray (which is actually finally underway) (iii) we probably seldom need to select individual grid points from theObviously the array has more dimensions, likely
"time"
and"member"
(or"realization"
)."gp"
,"lon"
, and"lat"
with"_i"
, and"_j"
:I.e. the array would look like:
The text was updated successfully, but these errors were encountered: