Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fmt] Format all #4885

Merged
merged 1 commit into from
Jan 8, 2025
Merged

[fmt] Format all #4885

merged 1 commit into from
Jan 8, 2025

Conversation

RMeli
Copy link
Member

@RMeli RMeli commented Jan 8, 2025

Excluding the files touched by open PRs excluded in #4815, this PR removes the explicit inclusion of files, and formats the last remaining file. Only the explicitly ignored files are not formatted, and will be formatted once the associated PRs are merged.

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4885.org.readthedocs.build/en/4885/

@RMeli RMeli requested review from orbeckst and marinegor January 8, 2025 21:08
Copy link
Member Author

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing fishy, LGTM.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 ... getting towards the finish line 🏁

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (5eef341) to head (3da154f).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
package/MDAnalysis/__init__.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4885      +/-   ##
===========================================
- Coverage    93.66%   93.63%   -0.03%     
===========================================
  Files          177      189      +12     
  Lines        21795    22861    +1066     
  Branches      3067     3067              
===========================================
+ Hits         20414    21407     +993     
- Misses         929     1002      +73     
  Partials       452      452              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RMeli RMeli merged commit 263bbe6 into MDAnalysis:develop Jan 8, 2025
25 of 26 checks passed
@RMeli RMeli deleted the fmt-all branch January 8, 2025 22:06
Copy link
Contributor

@marinegor marinegor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retrospective LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants