Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create greetings.yml #3609

Merged
merged 7 commits into from
Apr 11, 2022
Merged

Create greetings.yml #3609

merged 7 commits into from
Apr 11, 2022

Conversation

hmacdope
Copy link
Member

@hmacdope hmacdope commented Apr 7, 2022

Greet first time contributors.

Changes made in this Pull Request:

  • Added a greeting asking people to introduce themselves and abide by COC.

hmacdope added 2 commits April 7, 2022 10:24
Greet first time contributors.
@hmacdope hmacdope requested review from IAlibay and orbeckst April 7, 2022 00:29
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #3609 (6c7c043) into develop (3d8c75c) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3609      +/-   ##
===========================================
+ Coverage    94.21%   94.23%   +0.01%     
===========================================
  Files          190      190              
  Lines        24725    24752      +27     
  Branches      3321     3329       +8     
===========================================
+ Hits         23295    23324      +29     
+ Misses        1382     1380       -2     
  Partials        48       48              
Impacted Files Coverage Δ
package/MDAnalysis/coordinates/MOL2.py 97.63% <0.00%> (ø)
package/MDAnalysis/topology/MOL2Parser.py 99.12% <0.00%> (+0.22%) ⬆️
package/MDAnalysis/analysis/lineardensity.py 87.65% <0.00%> (+3.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d8c75c...6c7c043. Read the comment docs.

@RMeli
Copy link
Member

RMeli commented Apr 7, 2022

Since this gets triggered on new PRs, it should also tell people to add themselves to the AUTHORS list? Changes to AUTHORS are often (always?) missing and reviewers have to explain this each time.

Worth mentioning Discord as well?

@IAlibay
Copy link
Member

IAlibay commented Apr 7, 2022

I'll push change a bit later today, but this needs to be limited to the core MDA repo, don't want folks playing around with forks getting bothered with this.

@hmacdope
Copy link
Member Author

hmacdope commented Apr 7, 2022

Anyone feel free to push changes they want directly :)

- uses: actions/first-interaction@v1
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
pr-message: 'Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct (https://www.mdanalysis.org/pages/conduct/) and that first time contibutors introduce themselves on the developer mailing list (https://groups.google.com/g/mdnalysis-devel) so we can get to know you.'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pr-message: 'Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct (https://www.mdanalysis.org/pages/conduct/) and that first time contibutors introduce themselves on the developer mailing list (https://groups.google.com/g/mdnalysis-devel) so we can get to know you.'
pr-message: 'Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our [Code of Conduct](https://www.mdanalysis.org/pages/conduct/) and that first time contributors introduce themselves on the [developer mailing list](https://groups.google.com/g/mdnalysis-devel) and the [MDAnalysis Discord Server](https://discord.com/channels/807348386012987462/) so we can get to know you. Please also add yourself to `package/AUTHORS` as part of this PR.'

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the Discord server I wouldn't link directly because that link is useless if you haven't been invited. https://www.mdanalysis.org/#participating has the discord information.

Copy link
Member

@IAlibay IAlibay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and directly made changes, sorry just was faster to do it.

I've explained my changes below.

.github/workflows/gh-ci-cron.yaml Show resolved Hide resolved
.github/workflows/gh-ci.yaml Show resolved Hide resolved
.github/workflows/greetings.yaml Show resolved Hide resolved
.github/workflows/greetings.yaml Show resolved Hide resolved
.github/workflows/greetings.yaml Show resolved Hide resolved
Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greeting message looks good to me. Thanks for setting it up.

(I commented on a comment regarding discord, just saying that we can't directly link to our server, instead I suggest to link to https://www.mdanalysis.org/#participating .)

@IAlibay
Copy link
Member

IAlibay commented Apr 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IAlibay
Copy link
Member

IAlibay commented Apr 8, 2022

I'm not sure why azp is being so flaky, I'll try to re-run again.

Re: pypi checks - I suspect setuptools' recent version change is probably at fault here... this is going to be a long Friday evening.

@IAlibay
Copy link
Member

IAlibay commented Apr 8, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea of customized messages for new contributors.

However, does the message replace our standard template? That would not be good because I really want to encourage everyone to follow the structure in the template, including the "fixes" and checklist.

Note that actions/first-interaction also has a way to greet first time issue openers. Is this something we want to do??

.github/workflows/greetings.yaml Outdated Show resolved Hide resolved
@IAlibay
Copy link
Member

IAlibay commented Apr 9, 2022

I like the idea of customized messages for new contributors.

However, does the message replace our standard template? That would not be good because I really want to encourage everyone to follow the structure in the template, including the "fixes" and checklist.

This should just be a separate comment on the PR, it shouldn't affect the template.

Issue wise, I'd be reluctant at the moment. Sometimes I like to drop by an org, raise an issue about something but not necessarily be invested in that community. I'd prefer just let us handle the initial response.

@orbeckst
Copy link
Member

orbeckst commented Apr 9, 2022 via email

hmacdope and others added 2 commits April 11, 2022 09:12
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
@hmacdope hmacdope requested review from RMeli and orbeckst April 10, 2022 23:20
@hmacdope hmacdope merged commit 9d090e6 into develop Apr 11, 2022
@IAlibay IAlibay deleted the greet-1st-contributors branch May 29, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants