-
Notifications
You must be signed in to change notification settings - Fork 674
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create greetings.yml #3609
Create greetings.yml #3609
Conversation
Greet first time contributors.
Codecov Report
@@ Coverage Diff @@
## develop #3609 +/- ##
===========================================
+ Coverage 94.21% 94.23% +0.01%
===========================================
Files 190 190
Lines 24725 24752 +27
Branches 3321 3329 +8
===========================================
+ Hits 23295 23324 +29
+ Misses 1382 1380 -2
Partials 48 48
Continue to review full report at Codecov.
|
Since this gets triggered on new PRs, it should also tell people to add themselves to the AUTHORS list? Changes to AUTHORS are often (always?) missing and reviewers have to explain this each time. Worth mentioning Discord as well? |
I'll push change a bit later today, but this needs to be limited to the core MDA repo, don't want folks playing around with forks getting bothered with this. |
Anyone feel free to push changes they want directly :) |
.github/workflows/greetings.yml
Outdated
- uses: actions/first-interaction@v1 | ||
with: | ||
repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
pr-message: 'Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct (https://www.mdanalysis.org/pages/conduct/) and that first time contibutors introduce themselves on the developer mailing list (https://groups.google.com/g/mdnalysis-devel) so we can get to know you.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pr-message: 'Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct (https://www.mdanalysis.org/pages/conduct/) and that first time contibutors introduce themselves on the developer mailing list (https://groups.google.com/g/mdnalysis-devel) so we can get to know you.' | |
pr-message: 'Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our [Code of Conduct](https://www.mdanalysis.org/pages/conduct/) and that first time contributors introduce themselves on the [developer mailing list](https://groups.google.com/g/mdnalysis-devel) and the [MDAnalysis Discord Server](https://discord.com/channels/807348386012987462/) so we can get to know you. Please also add yourself to `package/AUTHORS` as part of this PR.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the Discord server I wouldn't link directly because that link is useless if you haven't been invited. https://www.mdanalysis.org/#participating has the discord information.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went ahead and directly made changes, sorry just was faster to do it.
I've explained my changes below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greeting message looks good to me. Thanks for setting it up.
(I commented on a comment regarding discord, just saying that we can't directly link to our server, instead I suggest to link to https://www.mdanalysis.org/#participating .)
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
I'm not sure why azp is being so flaky, I'll try to re-run again. Re: pypi checks - I suspect setuptools' recent version change is probably at fault here... this is going to be a long Friday evening. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea of customized messages for new contributors.
However, does the message replace our standard template? That would not be good because I really want to encourage everyone to follow the structure in the template, including the "fixes" and checklist.
Note that actions/first-interaction also has a way to greet first time issue openers. Is this something we want to do??
This should just be a separate comment on the PR, it shouldn't affect the template. Issue wise, I'd be reluctant at the moment. Sometimes I like to drop by an org, raise an issue about something but not necessarily be invested in that community. I'd prefer just let us handle the initial response. |
Makes sense, I’m fine with PR-only message.
… Am 4/8/22 um 22:37 schrieb Irfan Alibay ***@***.***>:
Issue wise, I'd be reluctant at the moment. Sometimes I like to drop by an org, raise an issue about something but not necessarily be invested in that community. I'd prefer just let us handle the initial response.
|
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
Greet first time contributors.
Changes made in this Pull Request: