Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completes removal of old hbonds code #3171

Closed
wants to merge 3 commits into from

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Mar 15, 2021

Towards #2739

Changes made in this Pull Request:

  • removes hbonds.hbond_analysis
  • removes hbonds.hbond_autocorrel

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #3171 (88bca69) into develop (6282385) will decrease coverage by 4.60%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3171      +/-   ##
===========================================
- Coverage    92.73%   88.12%   -4.61%     
===========================================
  Files          168      165       -3     
  Lines        22679    21856     -823     
  Branches      3213     3108     -105     
===========================================
- Hits         21031    19261    -1770     
- Misses        1600     2593     +993     
+ Partials        48        2      -46     
Impacted Files Coverage Δ
package/MDAnalysis/analysis/__init__.py 100.00% <ø> (ø)
...DAnalysis/analysis/hydrogenbonds/hbond_analysis.py 98.63% <ø> (ø)
package/MDAnalysis/analysis/waterdynamics.py 95.55% <ø> (-0.04%) ⬇️
package/MDAnalysis/topology/ParmEdParser.py 13.28% <0.00%> (-85.17%) ⬇️
package/MDAnalysis/topology/RDKitParser.py 14.52% <0.00%> (-82.09%) ⬇️
package/MDAnalysis/coordinates/RDKit.py 16.15% <0.00%> (-81.17%) ⬇️
package/MDAnalysis/coordinates/ParmEd.py 12.99% <0.00%> (-78.02%) ⬇️
package/MDAnalysis/analysis/hole2/hole.py 14.47% <0.00%> (-58.72%) ⬇️
package/MDAnalysis/analysis/hole2/utils.py 24.52% <0.00%> (-51.58%) ⬇️
package/MDAnalysis/due.py 61.11% <0.00%> (-13.89%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6282385...88bca69. Read the comment docs.

@IAlibay
Copy link
Member Author

IAlibay commented Mar 15, 2021

Closing based on: #2987 (comment)

@IAlibay IAlibay closed this Mar 15, 2021
@IAlibay IAlibay deleted the remove-hbond_autocorr branch March 15, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant