cleaned up lib.log #2902
Merged
cleaned up lib.log #2902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix #2734 (docs now build with sphinx 2.3) - removed unused code from lib.log (left over from ProgressMeter removal) - explicitly added docs to ProgressMeter - avoids sphinx failure due to wrong formatting in tqdm.auto.tqdm - add specific example for MDA - document our own verbose kwarg - improved markup - not documented: gui kwarg (discouraged in original docs)
Codecov Report
@@ Coverage Diff @@
## develop #2902 +/- ##
===========================================
+ Coverage 92.89% 92.94% +0.04%
===========================================
Files 187 187
Lines 24587 24570 -17
Branches 3192 3189 -3
===========================================
- Hits 22840 22836 -4
+ Misses 1701 1688 -13
Partials 46 46
Continue to review full report at Codecov.
|
|
@jbarnoud would you mind looking after this PR, please? |
richardjgowers
approved these changes
Aug 14, 2020
orbeckst
added a commit
that referenced
this pull request
Aug 16, 2020
- fix #2734 (docs now build with sphinx 2.3) - formally deprecated lib.log.echo() (CHANGELOG, @deprecate, and test) - explicitly added docs to ProgressMeter - avoids sphinx failure due to wrong formatting in tqdm.auto.tqdm - add specific example for MDA - document our own verbose kwarg - improved markup - not documented: gui kwarg (discouraged in original docs) (cherry picked from commit 5e68617)
PicoCentauri
pushed a commit
to PicoCentauri/mdanalysis
that referenced
this pull request
Mar 30, 2021
- fix MDAnalysis#2734 (docs now build with sphinx 2.3) - removed unused code from lib.log (left over from ProgressMeter removal) - explicitly added docs to ProgressMeter - avoids sphinx failure due to wrong formatting in tqdm.auto.tqdm - add specific example for MDA - document our own verbose kwarg - improved markup - not documented: gui kwarg (discouraged in original docs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2734
Changes made in this Pull Request:
PR Checklist