-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ProgressMeter #2743
Remove ProgressMeter #2743
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2743 +/- ##
===========================================
- Coverage 91.30% 91.25% -0.06%
===========================================
Files 176 176
Lines 24007 23967 -40
Branches 3159 3153 -6
===========================================
- Hits 21920 21871 -49
- Misses 1459 1470 +11
+ Partials 628 626 -2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say we add a versionchanged to the module docs to indicate that the class was removed. If nothing else it will help people to go back to 1.0 if they really can’t change their scripts. The way I see it, is that in this PR it is really easy to add the information, it will be hard and tedious if we later decide to do it or if we need to keep answer questions.
@@ -80,12 +80,11 @@ | |||
.. autogenerated, see Online Docs | |||
|
|||
""" | |||
from __future__ import print_function, division, absolute_import | |||
from __future__ import absolute_import | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I'll remove all the py2 stuff from lib at the same time.
And yay, -282 lines of code! Btw, if there’s widespread support for not adding versionchanged for dropped content then say so. I am just thinking that the technical docs can be technical and have useful information. Anything we put in the docs now will hopefully allow users to come to their own conclusions as opposed to us explaining. |
I think my main thing was that I wasn't too sure where the versionchanged should go, I've just placed one under "13.2.6.2. Other functions and classes for logging purposes" hopefully it looks reasonable. |
* removes PM from package * Remove PM tests * updates CHANGELOG * Remove tests * Adds docstring versionchange
Towards #2739
Changes made in this Pull Request:
Questions:
PR Checklist