-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for Gromacs's TNG format #865
Comments
And according to chatter on gmx-dev, it's being implemented in mdtraj. |
I took a minimal crack at this with some cython that exposes the coordinates to python. (no actual MDAnalysis reader though): Looking at the MDTraj progress, it looks like their reader is nearly complete if not entirely complete. |
@khuston that looks like a good start. You could keep the tng/Cython as a small interface like @kain88-de did here: Then write a Reader which uses this interface like here: https://github.com/MDAnalysis/mdanalysis/blob/develop/package/MDAnalysis/coordinates/XTC.py Don't worry about how to incorporate the Reader into MDA yet, that can wait until it's working nicely. WRT tests, you should be able to convert the XTC file in the tests to a TNG and just |
Is it realistic to have basic TNG support (at least reading fixed number of atoms) in 0.17.0? It would certainly look very good on the feature list. |
Can be closed with #3765 |
Fair point. |
Of the remaining I would say the ordering in terms of priority would go
I don't think time dependent topology is something we can really handle either right? So I would push that down the list a bit. |
Time-dependent topologies will require a fairly major overhaul of the whole library. Let's not go there for now. |
Fair enough, I unlinked this issue from PR #3765. This issue will be an forever-open issue... |
Gromacs is slowly moving toward the new TNG trajectory format. The format got introduced in the late releases of the 4 serie, and should become the default format eventually.
TNG allows better compression that XTC, and have random frame access built in. It also allows to store arbitrary data along side the trajectory (which may require #785), and time-dependant topology (which would require #864).
A library is provided by the gromacs people: https://github.com/gromacs/gromacs/tree/master/src/external/tng_io
See the paper: http://onlinelibrary.wiley.com/doi/10.1002/jcc.23495/full
Full support for the TNG format can be implemented in parts:
The text was updated successfully, but these errors were encountered: