-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PDB hybrid36 format (Packmol PDB files with hexadecimal numbers) #1897
Comments
https://www-s.ks.uiuc.edu/Research/namd/mailing_list/namd-l.2015-2016/0569.html VMD might do something similar. |
http://thegrantlab.org/bio3d/html/read.pdb.html yup now I'm pretty sure VMD supports hex numbers. VMD will also be an easy way to generate a test file |
Ok but packmol only numbers hexidecimally *after* 99,999 😂 maybe that’s a
bug to report
…On Sat, May 12, 2018 at 11:00 AM, Max Linke ***@***.***> wrote:
http://thegrantlab.org/bio3d/html/read.pdb.html yup now I'm pretty sure
VMD supports hex numbers. VMD will also be an easy way to generate a test
file
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1897 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI0jB4wcLv2ZWqUZtK2PT5dph7WsfdmLks5txvkngaJpZM4T8cMh>
.
|
I'm not sure if VMD doesn't do that too. |
Ah apparently VMD does the same. Which means we'd have to read more than 16 lines to check this. I think this will be fairly easy to fix, but harder to fix with no performance loss, which is preferable as huge PDB files are commonly used. |
Yeah from what I read that’s the standard... odd.
…On Sat, May 12, 2018 at 11:56 AM, Max Linke ***@***.***> wrote:
I'm not sure if VMD doesn't do that too.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#1897 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AI0jB1JieA-it6A4iFIf8wPveKV_6-Wxks5txwYggaJpZM4T8cMh>
.
|
There's a version of the "PDB format" that uses hexadecimals called hybrid-36. (This was discussed in openmm/openmm#659 a while ago.) We can support hybrid-36 either separately with our PDBReader. (I have to say I don't feel very good about having our reader automatically trying to recognize every custom variation of the PDB format; perhaps we could have a flag like the old "strict=True" that actually fails when the format is not the true PDB one.... or at least a warning.) |
@orbeckst yeah maybe it would be better if you had to specify that this is required via keyword args. It might also make the resulting code cleaner/faster |
I saw https://plumed.github.io/doc-v2.4/user-doc/html/pdbreader.html
Note the comment on VMD apparently doing its own thing vs following the hybrid-36 standard. (See also plumed/plumed2#226 ) What does packmol really do? VMD-style or hybrid-36? I am all for supporting hybrid-36. Sample code: https://sourceforge.net/p/cctbx/code/HEAD/tree/trunk/iotbx/pdb/hybrid_36.py |
Does it make sense to allow this format also for residue ids? |
Here's a really funny one packmol writes PDB indices in hexadecimal when they get too high. PDB really is the format that never stops giving
The text was updated successfully, but these errors were encountered: