Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed duplicated "Optional Tips & Tricks" section from doc guide #372

Merged
merged 1 commit into from
Aug 14, 2024
Merged

removed duplicated "Optional Tips & Tricks" section from doc guide #372

merged 1 commit into from
Aug 14, 2024

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst commented Aug 14, 2024 •
edited by github-actions bot
Loading

@orbeckst orbeckst requested review from lilyminium and RMeli August 14, 2024 04:16
RMeli
RMeli approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@RMeli RMeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super well versed with sphinx. Is the remaining .. _autobuild-sphinx: directive needed? I can't see it in other sections.

The rendering looks good to me.

orbeckst
orbeckst commented Aug 14, 2024
View reviewed changes
doc/source/contributing_docs.rst

The below sections are optional, but may be helpful for more advanced users.


.. _autobuild-sphinx:
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that line is still needed as an anchor for the next section.

@orbeckst
Copy link
Member Author

Thanks @RMeli.

In the interest of time I'll just merge.

@orbeckst orbeckst merged commit a08963a into develop Aug 14, 2024
5 checks passed
@orbeckst orbeckst deleted the remove-duplicate-section-opt-tips branch August 14, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMeli RMeli RMeli approved these changes

@lilyminium lilyminium Awaiting requested review from lilyminium

Assignees

@RMeli RMeli

@lilyminium lilyminium

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@orbeckst @RMeli @lilyminium