-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sdg23 update installation quick start page #440
base: master
Are you sure you want to change the base?
Sdg23 update installation quick start page #440
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes and updates. Please see comments below.
pages/installation_quick_start.md
Outdated
|
||
## Conda ## | ||
## Mamba ## |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably still contain the word "conda" because that's what people know.
## Mamba ## | |
## mamba/conda ## |
If you don't have [conda][] installed yet, follow the [installation | ||
instructions for conda][]. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should still have links to installing mamba/miniforge (see MDAnalysis/UserGuide#361 (comment) ) and conda. There are people who don't use it every day. It's important to give some minimal guidance. It's also a bit odd to recommend mamba but requiring people to somehow have conda already installed.
MDAnalysis via [mamba][] supports only serial calculations. | ||
For OpenMP-based parallelism, use [pip][] and ensure you have |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still true? @hmacdope ?
I'd say, look at the User Guide: Contributing / with conda-forge packages instructions for mamba installation. We recently rewrote those for the UGM and they look reasonable. Do NOT follow the standard UG conda installation instructions because they are not correct MDAnalysis/UserGuide#405 |
1ae92cc
to
48bad02
Compare
Thanks @orbeckst for your comments. I incorporated them. I kept it simple as this is the quick start guide, but happy to take more suggestions as to what level of detail should be included here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@jennaswa @micaela-matta do you also want to have a look or should we merge?
To be reviewed by @micaela-matta and @orbeckst.
This PR fixes #385.