Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo in most.m file for checking MinDown time #29

Closed
talha965 opened this issue Aug 30, 2022 · 1 comment
Closed

A typo in most.m file for checking MinDown time #29

talha965 opened this issue Aug 30, 2022 · 1 comment

Comments

@talha965
Copy link

Hi,
I was reading through the most. m file and I realized there is a small bug in checking the MinDown time to be >=1 on line 377 in the most.m file as shown below. The IF condition is only checking MinUp time twice.

if any(mdi.UC.MinUp < 1) && any(mdi.UC.MinUp < 1)
error('most: UC.MinUp and UC.MinDown must all be >= 1');
end
@talha965 talha965 changed the title A bug in most.m file for checking MinDown time A typo in most.m file for checking MinDown time Aug 30, 2022
@rdzman
Copy link
Member

rdzman commented Aug 30, 2022

Good catch! Thanks for letting me know. The fix will be in shortly.

rdzman added a commit that referenced this issue Aug 30, 2022
@rdzman
Fix #29, typo skipping check on md.UC.MinDown >= 1.
5ac6f78 
Thanks to Talha Iqbal.

Ref: #29
@rdzman rdzman closed this as completed in 617220b Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rdzman @talha965