Fjord calving fix #132
Open
Fjord calving fix #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes two adjustments: 1. When deciding if an edge should experience calving, include neighbors above sea level instead of just open ocean neighbors. This ensures fjord walls don’t “block” the calving expected at a cell based on its calvingVelocity 2. Adjust the scale_edge_length function to zero edges that are oriented in the opposite direction of the velocity. Previously orientation was ignored but this is now necessary to avoid calving at edges that have neighbors above sea level (item 1) facing the opposite direction as the velocity. # Please enter the commit message for your changes. Lines starting
4941445 to
028fdcf
Compare
It leverages the existing specified_calving_velocity option and simply adds the flow velocity to the desired retreat velocity to obtain the appropriate calvingVelocity.
028fdcf to
9962299
Compare
Neither vector should ever have magnitude zero, and if it does, it should be an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes calving in narrow fjords, which previously would occur at rates less than prescribed due to edges along fjord walls not being active for calving and reducing the calving flux.