Check return value of GetRayTracingCaptureReplayShaderGroupHandlesKHR [WIP] #1403
Conversation
|
CI gfxreconstruct build queued with queue ID 114983. |
|
CI gfxreconstruct build # 3663 running. |
|
CI gfxreconstruct build # 3663 failed. |
|
I think we generally fail if the call succeeded in capture and fails in replay. I think calling |
|
This PR failed internal CI because it caused recapture of the raytracing captures to fail. But they were actually failing silently, so a change to CI to represent this PR is appropriate. |
|
Once the clang-format issue reported by the GitHub Actions CI build is resolved ("CI Build / Ubuntu GCC Release") then please merge this PR. |
daa3916 to
4d5b930
Compare
|
CI gfxreconstruct build queued with queue ID 118613. |
|
CI gfxreconstruct build # 3677 running. |
|
CI gfxreconstruct build # 3677 failed. |
|
CI gfxreconstruct build queued with queue ID 118672. |
|
CI gfxreconstruct build # 3678 running. |
|
CI gfxreconstruct build # 3678 failed. |
|
CI gfxreconstruct build queued with queue ID 118729. |
|
CI gfxreconstruct build # 3680 running. |
|
CI gfxreconstruct build # 3680 passed. |
|
CI gfxreconstruct build queued with queue ID 121766. |
|
I'm going to re-run the tests just to be sure it wasn't a fluke (and that the current CI works with this change) |
|
CI gfxreconstruct build # 3687 running. |
|
CI gfxreconstruct build # 3687 passed. |
Would appreciate being given direction on whether the error handling is appropriate - the error code will be propagated upwards which may cause the application to fail (due to exiting on any error). It may also cause replay to fail because the error code for this command won't be VK_SUCCESS.