-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate cpp code to latest #1374
Integrate cpp code to latest #1374
Conversation
CI gfxreconstruct build queued with queue ID 90710. |
CI gfxreconstruct build # 3567 running. |
CI gfxreconstruct build # 3567 passed. |
5aeeb60
to
60047de
Compare
CI gfxreconstruct build queued with queue ID 100488. |
CI gfxreconstruct build # 3619 running. |
CI gfxreconstruct build # 3619 failed. |
CI gfxreconstruct build queued with queue ID 103009. |
CI gfxreconstruct build # 3627 running. |
CI gfxreconstruct build # 3627 passed. |
c09daae
to
3f034ed
Compare
CI gfxreconstruct build queued with queue ID 103196. |
CI gfxreconstruct build # 3630 running. |
CI gfxreconstruct build # 3630 passed. |
3f034ed
to
6c93334
Compare
CI gfxreconstruct build queued with queue ID 107322. |
CI gfxreconstruct build # 3636 running. |
CI gfxreconstruct build # 3636 passed. |
6c93334
to
6007e0e
Compare
CI gfxreconstruct build queued with queue ID 107639. |
CI gfxreconstruct build # 3637 running. |
6007e0e
to
50ff4b2
Compare
CI gfxreconstruct build queued with queue ID 107674. |
CI gfxreconstruct build # 3638 running. |
50ff4b2
to
166630b
Compare
CI gfxreconstruct build queued with queue ID 107719. |
CI gfxreconstruct build # 3640 running. |
CI gfxreconstruct build # 3640 passed. |
The resource tracker was unnecessary and all handle tracking is actually done by the VulkanCppConsumerBase itself.
Remove no longer needed post_ calls in generator
Moving to Ubuntu 22.04 for my system revealed new failures. Fixed them and a few unnecessary items in the struct generator python script.
Update the generated source to the headers for the latest rebase.
49d788d
to
b7366e4
Compare
CI gfxreconstruct build queued with queue ID 117580. |
CI gfxreconstruct build # 3672 running. |
CI gfxreconstruct build # 3672 passed. |
Talos replay on RADV encountered a fault. We weren't loading the appropriate function and attempted to dereference a null-pointer.
CI gfxreconstruct build queued with queue ID 120465. |
CI gfxreconstruct build # 3683 running. |
CI gfxreconstruct build # 3683 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if external/Tocpp-Android-Template/
is a public github repo. If it's, should we add the repo's link in external, like Vulkan-Headers, instead of copying it? Or we prefer to copy it?
1. Remove "or self.struct_names" in "vulkan_consumer_header_generator" This generator is to generate code for functions, so it's not for structures. 2. Set protect_file is True to generator "#ifndef" and "#define", instead of "#pragma once" 3. Modifiy ".h" to "\.h" in "base_generator" to fix "DISPAT_H" to "DISPATCH".
CI gfxreconstruct build queued with queue ID 145847. |
CI gfxreconstruct build # 3823 running. |
CI gfxreconstruct build queued with queue ID 145983. |
CI gfxreconstruct build # 3824 running. |
CI gfxreconstruct build # 3824 failed. |
CI gfxreconstruct build queued with queue ID 146476. |
CI gfxreconstruct build # 3830 running. |
CI gfxreconstruct build # 3830 failed. |
This change brings in the Samsung "toCpp" code generation to GFXReconstruct. The build for this tool is not enabled by default, and there is a README.md in the tool folder which states that it is considered to be in an Alpha state with some obvious holes. However, it does convert multiple game captures on my Linux system into an executable that can be run and modified.
Unfortunately, the way we brought the code in created a Blob of the original Samsung code, so it will be an large review process.