Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate cpp code to latest #1374

Closed

Conversation

MarkY-LunarG
Copy link
Contributor

This change brings in the Samsung "toCpp" code generation to GFXReconstruct. The build for this tool is not enabled by default, and there is a README.md in the tool folder which states that it is considered to be in an Alpha state with some obvious holes. However, it does convert multiple game captures on my Linux system into an executable that can be run and modified.

Unfortunately, the way we brought the code in created a Blob of the original Samsung code, so it will be an large review process.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 90710.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3567 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3567 passed.

@MarkY-LunarG MarkY-LunarG force-pushed the integrate_cpp_code_to_latest branch from 5aeeb60 to 60047de Compare December 13, 2023 15:05
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 100488.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3619 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3619 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 103009.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3627 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3627 passed.

@MarkY-LunarG MarkY-LunarG force-pushed the integrate_cpp_code_to_latest branch from c09daae to 3f034ed Compare December 18, 2023 20:49
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 103196.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3630 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3630 passed.

@MarkY-LunarG MarkY-LunarG force-pushed the integrate_cpp_code_to_latest branch from 3f034ed to 6c93334 Compare December 28, 2023 00:14
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 107322.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3636 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3636 passed.

@MarkY-LunarG MarkY-LunarG force-pushed the integrate_cpp_code_to_latest branch from 6c93334 to 6007e0e Compare December 28, 2023 15:38
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 107639.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3637 running.

@MarkY-LunarG MarkY-LunarG force-pushed the integrate_cpp_code_to_latest branch from 6007e0e to 50ff4b2 Compare December 28, 2023 16:48
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 107674.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3638 running.

@MarkY-LunarG MarkY-LunarG force-pushed the integrate_cpp_code_to_latest branch from 50ff4b2 to 166630b Compare December 28, 2023 18:32
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 107719.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3640 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3640 passed.

The resource tracker was unnecessary and all handle tracking is actually
done by the VulkanCppConsumerBase itself.
Remove no longer needed post_ calls in generator
Moving to Ubuntu 22.04 for my system revealed new failures.  Fixed
them and a few unnecessary items in the struct generator python
script.
Update the generated source to the headers for the latest rebase.
@MarkY-LunarG MarkY-LunarG force-pushed the integrate_cpp_code_to_latest branch from 49d788d to b7366e4 Compare January 16, 2024 18:46
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 117580.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3672 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3672 passed.

Talos replay on RADV encountered a fault.  We weren't loading the
appropriate function and attempted to dereference a null-pointer.
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 120465.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3683 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3683 passed.

Copy link
Contributor

@locke-lunarg locke-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if external/Tocpp-Android-Template/ is a public github repo. If it's, should we add the repo's link in external, like Vulkan-Headers, instead of copying it? Or we prefer to copy it?

framework/generated/generated_vulkan_dispatch_table.h Outdated Show resolved Hide resolved
framework/generated/generated_vulkan_consumer.h Outdated Show resolved Hide resolved
1. Remove "or self.struct_names" in "vulkan_consumer_header_generator"
This generator is to generate code for functions,
so it's not for structures.

2. Set protect_file is True to generator "#ifndef" and "#define",
instead of "#pragma once"

3. Modifiy ".h" to "\.h" in "base_generator" to fix "DISPAT_H" to "DISPATCH".
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 145847.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3823 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 145983.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3824 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3824 failed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 146476.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3830 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3830 failed.

@MarkY-LunarG MarkY-LunarG deleted the integrate_cpp_code_to_latest branch March 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants