build: remove requirement on distutils #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distutils is deprecated in Python 3.12. We were only using it for version number checking, and only for "."-separated lists of integers; we don't require the extended version syntax supported by PEP 440. Simple version checking can be done easily via list comparison of integers, which supports the same "less than" semantics as version comparison, without requiring any external dependency. build.py: - use lists of integers to reflect versions being compared
|
CI gfxreconstruct build queued with queue ID 78702. |
Merged
bradgrantham-lunarg
approved these changes
Nov 7, 2023
|
Waiting on internal CI run |
|
CI gfxreconstruct build # 3464 running. |
|
CI gfxreconstruct build # 3464 passed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
distutils is deprecated in Python 3.12. We were only using it for version number checking, and only for "."-separated lists of integers; we don't require the extended version syntax supported by PEP 440.
Simple version checking can be done easily via list comparison of integers, which supports the same "less than" semantics as version comparison, without requiring any external dependency.
build.py: