Add support for staging buffer/image for the Rebind Allocator. #1275
Conversation
Some traces are having corruptions due to missing support for non host visible memory Case not handled: Staging Image copy with offset Change-Id: I364d2c909bf0615f3d396339f0c83b0ffd1047af
|
Author laurentiu-erhan-arm not on autobuild list. Waiting for curator authorization before starting CI build. |
|
|
|
CI gfxreconstruct build queued with queue ID 50288. |
|
CI gfxreconstruct build # 3270 running. |
|
CI gfxreconstruct build # 3270 failed. |
Change-Id: Idde04893d1ab658f97e5c49241f87a270b0d76b0
|
CI gfxreconstruct build queued with queue ID 50605. |
|
CI gfxreconstruct build # 3273 running. |
|
CI gfxreconstruct build # 3273 failed. |
Change-Id: I070e2ca3bceeb30e08dc43214936cfc8c3fa058b
|
CI gfxreconstruct build queued with queue ID 56916. |
Change-Id: Idb2d718cda83307653ec766ad3ad615cde56786f
|
CI gfxreconstruct build queued with queue ID 56941. |
|
CI gfxreconstruct build # 3350 running. |
|
CI gfxreconstruct build # 3350 passed. |
| region.bufferOffset = 0; | ||
| region.bufferRowLength = 0; | ||
| region.bufferImageHeight = 0; | ||
| region.imageSubresource = { VK_IMAGE_ASPECT_COLOR_BIT, 0, 0, 1 }; |
There was a problem hiding this comment.
What happens in case of multiple mip maps / array layers?
There was a problem hiding this comment.
In the current implementation the other subresources would be ignored (except the first one). This is maybe a TODO for later.
There was a problem hiding this comment.
In that case I believe a GFXRECON_LOG_WARNING would be necessary, otherwise you might still get corruption (although less likely) but you won't get any hints about what might be causing it
There was a problem hiding this comment.
Thank you for the suggestion, i have added the warning messages
Change-Id: Ia679bbc1a480af30dbc990daeef01f70371a5219
|
CI gfxreconstruct build queued with queue ID 87876. |
|
CI gfxreconstruct build # 3540 running. |
|
CI gfxreconstruct build # 3540 passed. |
Some traces are having corruptions due to missing support for non host visible memory
Case not handled: Staging Image copy with offset