gfxrecon_replay: Use infinite timeout in vkAcquireNextImageKHR #1234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI gfxreconstruct build queued with queue ID 28459. |
|
CI gfxreconstruct build # 3110 running. |
|
CI gfxreconstruct build # 3110 passed. |
When replaying vkAcquireNextImageKHR and vkAcquireNextImageKHR2, use an infinite timeout in vkAcquireNextImageKHR* calls if the expected result is VK_SUCCESS. This prevents timeout errors during replay when the capture plays back faster than it did in the captured Vulkan program.
30b9679 to
de28a3b
Compare
|
CI gfxreconstruct build queued with queue ID 28944. |
|
CI gfxreconstruct build # 3117 running. |
|
CI gfxreconstruct build # 3117 passed. |
bradgrantham-lunarg
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When replaying vkAcquireNextImageKHR and vkAcquireNextImageKHR2, use an infinite timeout in vkAcquireNextImageKHR* calls if the expected result is VK_SUCCESS. This prevents timeout errors during replay when the capture plays back faster than it did in the captured Vulkan program.