Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable trimming to queue submission range #1204

Merged
merged 3 commits into from
Aug 24, 2023

Conversation

davidd-lunarg
Copy link
Contributor

Enable trimming based on a range of queue submissions--vkQueueSubmit for
Vulkan, ExecuteCommandLists for DX12. Trimming is activated immediately
before the first submission and deactivated immediately after the last
submission in the range(s) specified.

Also refactor uint range parsing to be shared between various command line options.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 9347.

@davidd-lunarg davidd-lunarg force-pushed the davidd-trim-to-queue-submit branch from 91a7b6b to cbc1313 Compare July 19, 2023 22:15
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 9352.

@davidd-lunarg davidd-lunarg force-pushed the davidd-trim-to-queue-submit branch from cbc1313 to 591483e Compare July 19, 2023 22:43
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 9361.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3004 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3004 passed.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 23467.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3085 running.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3085 passed.

Copy link
Contributor

@bradgrantham-lunarg bradgrantham-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with just the one note about naming uint_range variable

framework/util/options.cpp Show resolved Hide resolved
Enable trimming based on a range of queue submissions--vkQueueSubmit for
Vulkan, ExecuteCommandLists for DX12. Trimming is activated immediately
before the first submission and deactivated immediately after the last
submission in the range(s) specified.
@davidd-lunarg davidd-lunarg force-pushed the davidd-trim-to-queue-submit branch from 891c9d5 to cb88ee8 Compare August 24, 2023 18:36
@ci-tester-lunarg
Copy link

CI gfxreconstruct build queued with queue ID 29677.

@ci-tester-lunarg
Copy link

CI gfxreconstruct build # 3128 running.

@davidd-lunarg davidd-lunarg merged commit 5a36b07 into LunarG:dev Aug 24, 2023
@davidd-lunarg davidd-lunarg deleted the davidd-trim-to-queue-submit branch August 24, 2023 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants