-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable trimming to queue submission range #1204
Enable trimming to queue submission range #1204
Conversation
CI gfxreconstruct build queued with queue ID 9347. |
91a7b6b
to
cbc1313
Compare
CI gfxreconstruct build queued with queue ID 9352. |
cbc1313
to
591483e
Compare
CI gfxreconstruct build queued with queue ID 9361. |
CI gfxreconstruct build # 3004 running. |
CI gfxreconstruct build # 3004 passed. |
591483e
to
891c9d5
Compare
CI gfxreconstruct build queued with queue ID 23467. |
CI gfxreconstruct build # 3085 running. |
CI gfxreconstruct build # 3085 passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with just the one note about naming uint_range
variable
Enable trimming based on a range of queue submissions--vkQueueSubmit for Vulkan, ExecuteCommandLists for DX12. Trimming is activated immediately before the first submission and deactivated immediately after the last submission in the range(s) specified.
891c9d5
to
cb88ee8
Compare
CI gfxreconstruct build queued with queue ID 29677. |
CI gfxreconstruct build # 3128 running. |
Enable trimming based on a range of queue submissions--
vkQueueSubmit
forVulkan,
ExecuteCommandLists
for DX12. Trimming is activated immediatelybefore the first submission and deactivated immediately after the last
submission in the range(s) specified.
Also refactor uint range parsing to be shared between various command line options.