Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration for LUMI #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Configuration for LUMI #3

wants to merge 7 commits into from

Conversation

mszpindler
Copy link

No description provided.

@rsarm rsarm self-requested a review March 29, 2022 14:41
config/lumi.py Outdated
# SPDX-License-Identifier: BSD-3-Clause
#
# ReFrame CSCS settings
#
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can remove this header?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

config/lumi.py Outdated
'descr': 'LUMI Cray EX Supercomputer',
'hostnames': ['ln\d+-nmn', 'uan\d+-nmn.local', '\S+'],
'modules_system': 'lmod',
'resourcesdir': '/projappl/%s/reframe_resources/' % project,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'resourcesdir': '/projappl/%s/reframe_resources/' % project,
'resourcesdir': f'/projappl/{project}/reframe_resources/',

I would use fstrings on this file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@mszpindler mszpindler requested a review from olouant March 31, 2022 08:12
@mszpindler
Copy link
Author

@olouant I am not sure if craype-accel module and cflags+ldflags are not doing essentially the same.

@mszpindler mszpindler changed the title Access modules for target partition Configuration for LUMI Apr 4, 2022
@olouant
Copy link

olouant commented Apr 5, 2022

Yes, with the Cray compiler you can ommit the linking flags to the GTL library if craype-accel is loaded. With hipcc it's you still need to pass the flags to link with the GTL library.

mszpindler pushed a commit that referenced this pull request Oct 21, 2022
* Fix unit test failure
* Fix code style + code cleanup
* Add a proper comment before the `assert_process_died()`assertions
* Revert change in remote autodetect code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants