Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mask workspace local dependencies #171

Merged

Conversation

oddgrd
Copy link
Contributor

@oddgrd oddgrd commented Dec 5, 2022

This PR applies version masking to local workspace dependencies. I ran into this when starting to implement workspace inheritance at shuttle: shuttle-hq/shuttle#506. I tested it out by cloning my branch of cargo-chef in our Containerfile, and that caused the builds to succeed.

This is my first PR to cargo-chef, so please let me know if I've misunderstood anything. 😄

Closes #167

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@LukeMathWalker
Copy link
Owner

That looks perfect, thanks for the contribution!

@LukeMathWalker LukeMathWalker merged commit 2e6e4fd into LukeMathWalker:main Dec 7, 2022
@oddgrd oddgrd deleted the feat/mask-workspace-dependencies branch December 7, 2022 10:57
@oddgrd
Copy link
Contributor Author

oddgrd commented Dec 7, 2022

My pleasure, thanks for the quick release!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Local workspace.dependencies versions are not being masked
2 participants