Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiadapter support & sentry аdapter implementation #14

Merged
merged 30 commits into from
Feb 8, 2021
Merged

Multiadapter support & sentry аdapter implementation #14

merged 30 commits into from
Feb 8, 2021

Conversation

veseo
Copy link
Contributor

@veseo veseo commented Feb 8, 2021

No description provided.

Veselin Bakov added 12 commits February 4, 2021 11:41
Bumped lodash version.
9a0c90a
Sentry adapter in progress
65a4a55
Added support for multiple adapters.
e0bf6fd
Moved logLevel to be configurable per-adapter.
dc83e17
Renamed log level priorities const. Updated README for usage examples…
0e8a640 
… and general update to the new interface of the package. Bumped version.
Added support for handling exceptions
737b0b1
Refactored tests slightly. Now throwing AssertionError when construct…
4ea16cb 
…ing any adapter without config.
Added config sentry for debug mode.
7ba152d
Added configurability to not display dates in the logs. Improved READ…
c2af418 
…ME slightly.
Moved common configuration for all adapters to an abstract class, whi…
b6dafc6 
…ch the other adapters then extend.
Bumped eslint-rules version and fixed some of the eslint warnings.
260dd46
Moved formatDate to the base adapter class.
1bdb112
Dobri9909
Dobri9909 reviewed Feb 8, 2021
View reviewed changes
src/Logger.ts Outdated Show resolved Hide resolved
nikksan
nikksan reviewed Feb 8, 2021
View reviewed changes
README.md Show resolved Hide resolved
nikksan
nikksan reviewed Feb 8, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
Dobri9909
Dobri9909 reviewed Feb 8, 2021
View reviewed changes
src/LoggerFactory.ts Outdated Show resolved Hide resolved
nikksan
nikksan reviewed Feb 8, 2021
View reviewed changes
README.md Show resolved Hide resolved
nikksan
nikksan reviewed Feb 8, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
nikksan
nikksan reviewed Feb 8, 2021
View reviewed changes
src/LoggerFactory.ts Outdated Show resolved Hide resolved
@LuckboxGG LuckboxGG deleted a comment from veseo Feb 8, 2021
LoggerAdapter no longer implements the interface, to actually make se…
53a218b 
…nse for the adapter implementations to need to implement it (to force having an actual .log method).
Veselin Bakov added 12 commits February 8, 2021 12:35
Code readability improvements.
fb70105
Code readability improvements.
2b121ed
Marked log method in LoggedAdapter to remove "extends implements" red…
8fdb857 
…undancy.
tracesSampleRate is now hardcoded as 1
bd9d883
Serialization (if necessary) now done in a protected method in the ma…
aeb53fb 
…in class. Also implemented GoogleChromeLabs/jsbi#30. Renamed interface to LoggerAdapterInterface and no longer exporting it.
Better separation of constructor params and adapter configs.
e1d00fc
Removed redundant (and broken) import
a2426f6
Removed redundant interface. Fixed broken and warning-throwing tests …
bd3e148 
…with castings.
Slightly more refactoring (or is it..)
8033c58
Removed leftover from readme.
f8b76bd
Further readability improvements.
fc69809
Further readability improvements.
2f88d95
@tecs tecs merged commit cf324bb into LuckboxGG:master Feb 8, 2021
@veseo veseo deleted the sentry branch February 22, 2021 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dobri9909 Dobri9909 Dobri9909 left review comments

@nikksan nikksan nikksan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@veseo @nikksan @Dobri9909 @tecs