Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix appveyor #58

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Fix appveyor #58

merged 1 commit into from
Oct 23, 2017

Conversation

rducom
Copy link
Contributor

@rducom rducom commented Oct 18, 2017

Le problème : dotnet test termine avec un ErrorLevel = 1 si parmis les csproj de la solution existent des projets qui ne sont pas des projets de test.

Cf. https://github.com/dotnet/cli/issues/7447 microsoft/vstest#1129 microsoft/vstest#705

La solution : utiliser l'option -mergeoutput de OpenCover et tester csproj par csproj

J'ai aussi fixé la collection des artefacts .nupkg

Side-effect : j'ai découvert qu'on a 2 versions de OpenConver dans le $PATH sur AppVeyor, et la première n'étais forcément pas la bonne.

@rducom rducom self-assigned this Oct 18, 2017
nfaugout-lucca
nfaugout-lucca previously approved these changes Oct 18, 2017
Copy link
Contributor

@nfaugout-lucca nfaugout-lucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vu qu'on est sur du yml, qui est moins facile à lire/comprendre que du C#, une petite description de ce que cette PR fait dans la description de la PR ne serait pas du luxe, sinon j'ai l'impression d'approuver dans le vide ;)

@rducom
Copy link
Contributor Author

rducom commented Oct 18, 2017

Ben là c'est dans le vide car ça marche toujours pas... Je ferait une description quand ça marchera

@codecov-io
Copy link

codecov-io commented Oct 21, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@fefe9f5). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #58   +/-   ##
=========================================
  Coverage          ?   30.93%           
=========================================
  Files             ?       87           
  Lines             ?     2945           
  Branches          ?      293           
=========================================
  Hits              ?      911           
  Misses            ?     1947           
  Partials          ?       87

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefe9f5...a4c7be3. Read the comment docs.

@rducom
Copy link
Contributor Author

rducom commented Oct 21, 2017

@nfaugout @GMouron c'est ready to review & merge

@rducom rducom merged commit 43777b2 into master Oct 23, 2017
@rducom rducom deleted the fix.appveyor branch October 23, 2017 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants