forked from prebid/Prebid.js
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARGO-715 added change to fall back to the TCF cookies when no data is… #7
Open
Tonsil
wants to merge
4
commits into
master
Choose a base branch
from
feature/ARGO-715_tcf_in_cookies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4f1285f
ARGO-715 added change to fall back to the TCF cookies when no data is…
Tonsil 551de47
ARGO-715 removed conditional, added handling for case where no consen…
Tonsil 386fc06
ARGO-715 reworked the logic to make the two consent values wholly ind…
Tonsil 3c7e394
ARGO-715 updated the test suite for one with neither the consent obje…
Tonsil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ARGO-715 removed conditional, added handling for case where no consen…
…tString is supplied.
- Loading branch information
commit 551de47ba9b3e8d7e6862cc766a04133ba2876f7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -503,4 +503,32 @@ describe('LotameId', function() { | |
); | ||
}); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. please add one more where there are no cookies to fall back to confirming that we don't add the query params There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done! |
||
}); | ||
|
||
describe('when gdpr applies but no consent string is available', function () { | ||
let request; | ||
let callBackSpy = sinon.spy(); | ||
let consentData = { | ||
gdprApplies: true, | ||
consentString: undefined | ||
}; | ||
|
||
beforeEach(function () { | ||
let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback; | ||
submoduleCallback(callBackSpy); | ||
|
||
// the contents of the response don't matter for this | ||
request = server.requests[0]; | ||
request.respond(200, responseHeader, ''); | ||
}); | ||
|
||
it('should call the remote server when getId is called', function () { | ||
expect(callBackSpy.calledOnce).to.be.true; | ||
}); | ||
|
||
it('should not include the gdpr consent string on the url', function() { | ||
expect(request.url).to.be.eq( | ||
'https://id.crwdcntrl.net/id?gdpr_applies=true' | ||
); | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm - i would have expected the unit tests to catch this so maybe an update is needed there but this entire block doesn't get entered if there is no consentData object populated.