Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARGO-715 added change to fall back to the TCF cookies when no data is… #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ARGO-715 removed conditional, added handling for case where no consen…
…tString is supplied.
  • Loading branch information
Tonsil committed Jan 12, 2021
commit 551de47ba9b3e8d7e6862cc766a04133ba2876f7
18 changes: 9 additions & 9 deletions modules/lotamePanoramaIdSystem.js
Original file line number Diff line number Diff line change
@@ -188,15 +188,15 @@ export const lotamePanoramaIdSubmodule = {

if (consentData && utils.isBoolean(consentData.gdprApplies)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm - i would have expected the unit tests to catch this so maybe an update is needed there but this entire block doesn't get entered if there is no consentData object populated.

queryParams.gdpr_applies = consentData.gdprApplies;
if (consentData.gdprApplies) {
let consentString = consentData.consentString;
// If no consent string in the data, try to read it from 1st party cookies
if (!consentString) {
consentString = getFromStorage('eupubconsent-v2');
}
if (!consentString) {
consentString = getFromStorage('euconsent-v2');
}
let consentString = consentData.consentString;
// If no consent string in the data, try to read it from 1st party cookies
if (!consentString) {
consentString = getFromStorage('eupubconsent-v2');
}
if (!consentString) {
consentString = getFromStorage('euconsent-v2');
}
if (consentString) {
queryParams.gdpr_consent = consentString;
}
}
28 changes: 28 additions & 0 deletions test/spec/modules/lotamePanoramaIdSystem_spec.js
Original file line number Diff line number Diff line change
@@ -503,4 +503,32 @@ describe('LotameId', function() {
);
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add one more where there are no cookies to fall back to confirming that we don't add the query params

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

});

describe('when gdpr applies but no consent string is available', function () {
let request;
let callBackSpy = sinon.spy();
let consentData = {
gdprApplies: true,
consentString: undefined
};

beforeEach(function () {
let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback;
submoduleCallback(callBackSpy);

// the contents of the response don't matter for this
request = server.requests[0];
request.respond(200, responseHeader, '');
});

it('should call the remote server when getId is called', function () {
expect(callBackSpy.calledOnce).to.be.true;
});

it('should not include the gdpr consent string on the url', function() {
expect(request.url).to.be.eq(
'https://id.crwdcntrl.net/id?gdpr_applies=true'
);
});
});
});