Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed class B multicast handling in LoRaMacClassBProcessMulticastSlot() #1277

Merged
merged 1 commit into from
Mar 10, 2022
Merged

Fixed class B multicast handling in LoRaMacClassBProcessMulticastSlot() #1277

merged 1 commit into from
Mar 10, 2022

Conversation

MarekNovakACRIOS
Copy link
Contributor

  • if a channel is not enabled, do not compute ping offset in ComputePingOffset(), I was getting a situation with "modulo zero" leading to a hard fault with a disabled channel being passed to ComputePingOffset() in LoRaMacClassBProcessMulticastSlot().
  • do not use hard-coded constant of 4 instead of LORAMAC_MAX_MC_CTX macro - if this macro is changed to for example 2, then a hard fault or out of bound array access situation can happen.

@MarekNovakACRIOS MarekNovakACRIOS mentioned this pull request Mar 9, 2022
Closed
mluis1
mluis1 requested changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@mluis1 mluis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposition.

Before merging could you please push the fix for the 2 comments that I have.

@MarekNovakACRIOS
Copy link
Contributor Author

I have added the spaces, so it should be OK from coding style perspective.

@MarekNovakACRIOS MarekNovakACRIOS requested a review from mluis1 March 10, 2022 10:53
@mluis1 mluis1 merged commit bc9a93e into Lora-net:master Mar 10, 2022
@mluis1 mluis1 added this to the Release Version 4.7.0 milestone Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mluis1 mluis1 mluis1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Release Version 4.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MarekNovakACRIOS @mluis1