class-C RX2 window not working anymore? #699

gpgib6 · 2019-03-19T17:09:00Z

Hi, I haven't updated the LoRa stack in a while, I'm using 5.0.0 feature branch. Today I did an update and now the RX2 window seems to be broken.

Before the update, I can go to the MultiTech gateway and send a downlink at any time, the downlink is sent out right away and the device picks it up, no problems.
Now after the update, same thing, I send the downlink, it is sent out right away but the device pretends like nothing is going on, as if the continuous RX2 window didn't exist anymore.

What do you think went wrong? Is there anything I can check?
For the time being I went back to the previous version of the stack but here I'm dealing with the rare condition where the lora stack gets stuck, thinking it's in TX mode.

mluis1 · 2019-03-22T13:23:49Z

Could you please provide the commit hash that is working as expected?
Could you please provide which example, platform that you are using?

We will provide a feedback as soon as possible

opt-liang · 2019-03-25T07:39:18Z

I also had similar problems with lorawan 1.03 development.

static void OpenContinuousRxCWindow( void )
{
MacCtx.RxWindowCConfig.RxSlot = RX_SLOT_WIN_CLASS_C;
// Setup continuous listening
MacCtx.RxWindowCConfig.RxContinuous = true;

//add
MacCtx.RxWindowCConfig.Channel = MacCtx.Channel;
MacCtx.RxWindowCConfig.Frequency = MacCtx.NvmCtx->MacParams.RxCChannel.Frequency;
MacCtx.RxWindowCConfig.DownlinkDwellTime = MacCtx.NvmCtx->MacParams.DownlinkDwellTime;
MacCtx.RxWindowCConfig.RepeaterSupport = MacCtx.NvmCtx->RepeaterSupport;
MacCtx.RxWindowCConfig.RxSlot = RX_SLOT_WIN_CLASS_C_MULTICAST;
MacCtx.RxWindowCConfig.RxContinuous = true;

// At this point the Radio should be idle.
// Thus, there is no need to set the radio in standby mode.
if( RegionRxConfig( MacCtx.NvmCtx->Region, &MacCtx.RxWindowCConfig, ( int8_t* )&MacCtx.McpsIndication.RxDatarate ) == true )
{
    Radio.Rx( 0 ); // Continuous mode
    MacCtx.RxSlot = MacCtx.RxWindowCConfig.RxSlot;
}

}

opt-liang · 2019-03-25T07:43:41Z

Set to CLASS_C device, but the second receiving window is not configured

opt-liang · 2019-03-25T07:50:08Z

I set the demo routine to CLASS_C, but MacCtx. Rx Windows CConfig. Frequency is 0

Mr-Techtron · 2019-04-19T05:32:21Z

Has anybody found why the frequency is set to 0?

gpgib6 · 2019-05-07T23:58:00Z

I'm using the 5.0.0 branch and this function gets called: void SX1276SetChannel( uint32_t freq )
The frequency is also set to 0 when it should be 923300000 or RX1 window I believe.

khomplora · 2019-05-29T14:04:37Z

I have the same problem :/

opt-liang · 2019-05-30T09:38:05Z

The code I posted can solve this problem temporarily.

opt-liang · 2019-05-30T09:38:45Z

In OpenContinuousRxCWindow function，add
//add
MacCtx.RxWindowCConfig.Channel = MacCtx.Channel;
MacCtx.RxWindowCConfig.Frequency = MacCtx.NvmCtx->MacParams.RxCChannel.Frequency;
MacCtx.RxWindowCConfig.DownlinkDwellTime = MacCtx.NvmCtx->MacParams.DownlinkDwellTime;
MacCtx.RxWindowCConfig.RepeaterSupport = MacCtx.NvmCtx->RepeaterSupport;
MacCtx.RxWindowCConfig.RxSlot = RX_SLOT_WIN_CLASS_C_MULTICAST;
MacCtx.RxWindowCConfig.RxContinuous = true;

mluis1 · 2019-06-17T11:55:43Z

Is this issue happening in both ABP and OTAA activation modes?

From our analysis it should only happen in ABP mode.

opt-liang · 2019-06-17T12:01:46Z

I only tested it in OTAA.

mluis1 · 2019-06-17T12:03:32Z

Ok, thanks for the feedback.

Mr-Techtron · 2019-06-17T12:03:43Z

And I have tested in ABP mode.

…

On Mon, Jun 17, 2019, 5:47 PM yanzi418 ***@***.***> wrote: I only tested it in OTAA. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#699?email_source=notifications&email_token=AHHIEDI7AYNHHCP2WP2K3Z3P254LXA5CNFSM4G7SVQMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODX26HPY#issuecomment-502653887>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHHIEDPT5C7322BZQHYBKLLP254LXANCNFSM4G7SVQMA> .

mluis1 · 2019-06-17T13:38:33Z

@yanzi418 and @Mr-Techtron, Could you please check that the below patch solves the observed issue?
As each one is using a different activation method this will speedup the verification.

On my side I will check that the FUOTA project is still operating as expected.

Thanks in advance.

diff --git a/src/mac/LoRaMac.c b/src/mac/LoRaMac.c
index 319a86fb..145bcd47 100644
--- a/src/mac/LoRaMac.c
+++ b/src/mac/LoRaMac.c
@@ -2586,6 +2586,14 @@ static void ResetMacParameters( void )
     // Initialize channel index.
     MacCtx.Channel = 0;
     MacCtx.NvmCtx->LastTxChannel = MacCtx.Channel;
+
+    // Initialize Rx2 config parameters.
+    MacCtx.RxWindow2Config.Channel = MacCtx.Channel;
+    MacCtx.RxWindow2Config.Frequency = MacCtx.NvmCtx->MacParams.Rx2Channel.Frequency;
+    MacCtx.RxWindow2Config.DownlinkDwellTime = MacCtx.NvmCtx->MacParams.DownlinkDwellTime;
+    MacCtx.RxWindow2Config.RepeaterSupport = MacCtx.NvmCtx->RepeaterSupport;
+    MacCtx.RxWindow2Config.RxContinuous = false;
+    MacCtx.RxWindow2Config.RxSlot = RX_SLOT_WIN_2;
 }
 
 /*!

khomplora · 2019-06-17T16:11:11Z

@yanzi418 and @Mr-Techtron, Could you please check that the below patch solves the observed issue?
As each one is using a different activation method this will speedup the verification.

On my side I will check that the FUOTA project is still operating as expected.

Thanks in advance.

diff --git a/src/mac/LoRaMac.c b/src/mac/LoRaMac.c
index 319a86fb..145bcd47 100644
--- a/src/mac/LoRaMac.c
+++ b/src/mac/LoRaMac.c
@@ -2586,6 +2586,14 @@ static void ResetMacParameters( void )
     // Initialize channel index.
     MacCtx.Channel = 0;
     MacCtx.NvmCtx->LastTxChannel = MacCtx.Channel;
+
+    // Initialize Rx2 config parameters.
+    MacCtx.RxWindow2Config.Channel = MacCtx.Channel;
+    MacCtx.RxWindow2Config.Frequency = MacCtx.NvmCtx->MacParams.Rx2Channel.Frequency;
+    MacCtx.RxWindow2Config.DownlinkDwellTime = MacCtx.NvmCtx->MacParams.DownlinkDwellTime;
+    MacCtx.RxWindow2Config.RepeaterSupport = MacCtx.NvmCtx->RepeaterSupport;
+    MacCtx.RxWindow2Config.RxContinuous = false;
+    MacCtx.RxWindow2Config.RxSlot = RX_SLOT_WIN_2;
 }
 
 /*!

Work for me! (ABP)

mluis1 · 2019-06-28T07:59:18Z

We assume that the OTAA is also working as there is no feedback. We will apply this patch as soon as possible.

…ResetMacParameters function.

Pirakutu · 2019-07-24T09:13:13Z

Hi there, this is still not working correctly. For example when the device received a new set of RX2/RXC params per MAC command, these changes are saved into the NVM variables but not into the actual running variables. This is not too bad for the RX2 params, as these are set once the timer event kicks in after sending a message. However, the local RXC params are never updated. I added this to ScheduleTX in LoRaMac.c to solve the problem (the reason i added it there is that the servers usually change the devices RX2/RXC frequecies once they have received an answer from the node, as this is a ACK MAC command [triggers a tx needed event]):

// Compute Rx1 windows parameters
RegionComputeRxWindowParameters( MacCtx.NvmCtx->Region,
                                 RegionApplyDrOffset( MacCtx.NvmCtx->Region, MacCtx.NvmCtx->MacParams.DownlinkDwellTime, MacCtx.NvmCtx->MacParams.ChannelsDatarate, MacCtx.NvmCtx->MacParams.Rx1DrOffset ),
                                 MacCtx.NvmCtx->MacParams.MinRxSymbols,
                                 MacCtx.NvmCtx->MacParams.SystemMaxRxError,
                                 &MacCtx.RxWindow1Config );
// Compute Rx2 windows parameters
RegionComputeRxWindowParameters( MacCtx.NvmCtx->Region,
                                 MacCtx.NvmCtx->MacParams.Rx2Channel.Datarate,
                                 MacCtx.NvmCtx->MacParams.MinRxSymbols,
                                 MacCtx.NvmCtx->MacParams.SystemMaxRxError,
                                 &MacCtx.RxWindow2Config );

/* ADDED CODE */
if( ( MacCtx.NvmCtx->DeviceClass == CLASS_C ) && ( MacCtx.NvmCtx->NetworkActivation != ACTIVATION_TYPE_NONE ) )
{
    // We can only compute the RX C window parameters, if we are already
    // in class c mode and joined. We cannot setup an RX C window in case of any other
    // class type.
    // Update RxC frequency if it has changed
    if (MacCtx.RxWindowCConfig.Frequency !=  MacCtx.NvmCtx->MacParams.RxCChannel.Frequency){
      MacCtx.RxWindowCConfig.Frequency = MacCtx.NvmCtx->MacParams.Rx2Channel.Frequency;
    }
    // Compute RxC windows parameters if datarate has changed
    if (MacCtx.RxWindowCConfig.Datarate != MacCtx.NvmCtx->MacParams.RxCChannel.Datarate)
    RegionComputeRxWindowParameters( MacCtx.NvmCtx->Region,
                                     MacCtx.NvmCtx->MacParams.RxCChannel.Datarate,
                                     MacCtx.NvmCtx->MacParams.MinRxSymbols,
                                     MacCtx.NvmCtx->MacParams.SystemMaxRxError,
                                     &MacCtx.RxWindowCConfig );
}
/* ADDED CODE */

mluis1 added the bug label Jun 17, 2019

mluis1 added this to the Release Version 4.4.2 milestone Jun 17, 2019

mluis1 added a commit that referenced this issue Jul 2, 2019

Issue #699 - Added Rx2 config parameters structure initialization in …

895b6cd

…ResetMacParameters function.

mluis1 closed this as completed Jul 2, 2019

Pirakutu mentioned this issue Jul 24, 2019

Class C window settings still not working correctly #765

Closed

EduardoHM98 mentioned this issue Oct 25, 2023

Fix for Class C device functionality. htmicron/htlrbl32l#21

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

class-C RX2 window not working anymore? #699

class-C RX2 window not working anymore? #699

gpgib6 commented Mar 19, 2019

mluis1 commented Mar 22, 2019

opt-liang commented Mar 25, 2019

opt-liang commented Mar 25, 2019

opt-liang commented Mar 25, 2019

Mr-Techtron commented Apr 19, 2019

gpgib6 commented May 7, 2019

khomplora commented May 29, 2019

opt-liang commented May 30, 2019

opt-liang commented May 30, 2019

mluis1 commented Jun 17, 2019

opt-liang commented Jun 17, 2019

mluis1 commented Jun 17, 2019

Mr-Techtron commented Jun 17, 2019 via email

mluis1 commented Jun 17, 2019

khomplora commented Jun 17, 2019

mluis1 commented Jun 28, 2019

Pirakutu commented Jul 24, 2019

class-C RX2 window not working anymore? #699

class-C RX2 window not working anymore? #699

Comments

gpgib6 commented Mar 19, 2019

mluis1 commented Mar 22, 2019

opt-liang commented Mar 25, 2019

opt-liang commented Mar 25, 2019

opt-liang commented Mar 25, 2019

Mr-Techtron commented Apr 19, 2019

gpgib6 commented May 7, 2019

khomplora commented May 29, 2019

opt-liang commented May 30, 2019

opt-liang commented May 30, 2019

mluis1 commented Jun 17, 2019

opt-liang commented Jun 17, 2019

mluis1 commented Jun 17, 2019

Mr-Techtron commented Jun 17, 2019 via email

mluis1 commented Jun 17, 2019

khomplora commented Jun 17, 2019

mluis1 commented Jun 28, 2019

Pirakutu commented Jul 24, 2019