Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacCommandBufferIndex may be out of range in some cases #18

Closed
rossihwang opened this issue Oct 14, 2015 · 0 comments
Closed

MacCommandBufferIndex may be out of range in some cases #18

rossihwang opened this issue Oct 14, 2015 · 0 comments

Comments

@rossihwang
Copy link

I think the MacCommandBufferIndex should be checked In the beginning of function "AddMacCommand". When I repeat transmitting a mac command like LinkCheck, if the transmission failed, the MacCommandBufferIndex will ourt of it range in the current code.

in my opinion, it should be like:

static uint8_t AddMacCommand( uint8_t cmd, uint8_t p1, uint8_t p2 )
{
    if (MacCommandsBufferIndex == 14) {
        return 2;
    }

    MacCommandsBuffer[MacCommandsBufferIndex++] = cmd;
    switch( cmd )
    .......
}
@mluis1 mluis1 closed this as completed Oct 30, 2015
Cr0s added a commit to Cr0s/LoRaMac-node that referenced this issue Nov 2, 2016
According to the Table Lora-net#18 in SX1276 Datasheet, the CadDone interrupt is sitting on the DIO3 line, but we're setting some bits in DIO0 mapping instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants