-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSOE-675: Set StopOnFail option to true un xunit.runner.json for Lombiq.OSOCE.Tests.UI #612
Conversation
…sts.UI with StopOnFail set to true
"$schema": "https://xunit.net/schema/current/xunit.runner.schema.json", | ||
"parallelizeAssembly": false, | ||
"parallelizeTestCollections": true, | ||
"maxParallelThreads": 3, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on this code: https://github.com/Lombiq/GitHub-Actions/blob/dev/.github/actions/test-dotnet/Set-XUnitMaxParallelThreads.ps1#L21-L34
it will use the xunit.runner.json
's value. Which is not good since we are overriding it here: https://github.com/Lombiq/Open-Source-Orchard-Core-Extensions/blob/dev/.github/workflows/build-and-test.yml#L20
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DemeSzabolcs Should it just be to get rid of maxParallelThreads
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would be the simplest, yes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @DemeSzabolcs, I think I messed up with this PR.
I just closed it and open this other one: #616
@tteguayco Please also create an OSOCE PR with the submodule changes. |
Hey @DemeSzabolcs Isn't this the OSOCE PR? Also, it looks like |
@tteguayco Oh so sorry. For some reason I thought this was in the UI testing submodule. All good, ignore that comment. |
OSOE-675
This configuration file is ignored when running the tests directly from VisualStudio.
It takes the configuration file into consideration when running the tests via
dotnet test
.A related issue was opened: xunit/visualstudio.xunit#392