v2.0.0 #16
Merged
v2.0.0 #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert functions into static methods under the BladeSvgSage class Rewrite method that handles returning the cache busted SVG Keep existing get_svg helper but change to App namespace for global usage within Sage Register SvgFactory and Directives during class initilization Update blade-svg to 0.2.1 Clean up README Add MIT License Load BladeSvgSage with PSR-4 Lots of other little clean up / breaking changes– this is still a work in progress.
…standards Remove RelPath dependency Bump blade-svg to 0.3.0 Register BladeSvgSage with the sage container Remove a lot of unnecessary methods, instead falling back on blade-svg's internal methods for handling pathing, etc. Add @spritesheet directive Add config.php housing the default config that gets merged with the bladesvg filter Replace all existing configuration filters with bladesvg which accepts an array of values Replace helper functions with svg_image and svg_spritesheet, conforming with blade-svg Automatically handle theme pathing when passing a customized path for svg_path and spritesheet_path Update README with the new configuration filter as well as removing usage examples and instead referring to the original Blade SVG documentation as everything is now 1:1
Fix autoloading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A full refactor is in the works for Blade SVG Sage. This will include breaking changes but allow for much better maintainability moving forward.
Changelog
BladeSvgSageclass with a more appropriate naming scheme.config.phpfor housing the default configuration values.bladesvg, that accepts an array of values that get merged with the defaults.svg_pathandspritesheet_path(now defaults to theme root).SvgFactoryand Blade directives during the initialization of theBladeSvgSageclass withinafter_setup_themeinstead of awkwardly calling the action/filter twice.sagecontainer.svg_pathandspritesheet_pathtoresources/svgandresources/svg/spritesheet.svgrespectively to not only conform with vanilla Blade SVG and Laravel standards but remove the unnecessary issues that arise from the build process and BrowserSync.svg_image()andsvg_spritesheet()to theAppnamespace for use globally throughout Sage.empty()conditionals for$iconon methods where it is being used for a more graceful return instead of erroring.BladeSvgSageautoloading to PSR-4.composer.json..editorconfigand.gitignore.