Skip to content
This repository has been archived by the owner on Oct 13, 2024. It is now read-only.

fix: re-apply request label on comment command edit #2614

Merged

Conversation

ReenigneArcher
Copy link
Member

Description

  • re-apply request label on comment command edits in order to trigger new workflow run
  • fix undeclared variable issue on approve command
  • reduce number of api calls to add approve-queue and approve-theme labels
  • only edit issue if body actually changes

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link

codecov bot commented Jan 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (56b5ac5) 88.68% compared to head (124d1ac) 88.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2614   +/-   ##
=======================================
  Coverage   88.68%   88.68%           
=======================================
  Files           1        1           
  Lines         327      327           
=======================================
  Hits          290      290           
  Misses         37       37           

@ReenigneArcher ReenigneArcher merged commit 13e1079 into master Jan 5, 2024
12 checks passed
@ReenigneArcher ReenigneArcher deleted the fix-re-apply-request-label-on-comment-command-edit branch January 5, 2024 04:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant