Added Support for Custom Hosts/Regions #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
lluuaapp
commented
Sep 5, 2018
- changed Region from enum to struct
- can initialise region with custom host (e.g. 127.0.0.1)
- can disabled TLS/https for custom host
- disabled subdomain-buckets for custom host
- I tested this with Minio object storage server
This reverts commit 7940ea6.
rafiki270
reviewed
Sep 7, 2018
Sources/S3Signer/Region.swift
Outdated
|
|
||
| public struct Region { | ||
|
|
||
| public let name: RegionName |
There was a problem hiding this comment.
Please add helper comments to these
rafiki270
reviewed
Sep 7, 2018
Sources/S3Signer/Region.swift
Outdated
| } | ||
| } | ||
|
|
||
| public extension Region { |
There was a problem hiding this comment.
I don’t think the extension needs to have public, only methods within do
Sources/S3Signer/Region.swift
Outdated
| } | ||
|
|
||
| extension Region: Codable { | ||
| public init(from decoder: Decoder) throws { |
There was a problem hiding this comment.
Space and comment please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.