-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Swift package support #57
Conversation
Update source path.
…ill generate resource_bundle_generator.swift file.
@rafiki270 Please take a look and review it. |
Unfortunately there seems to be a problem with loading AwesomePro fonts. In Fonts.swift line 105 & 123, the use of |
is it crashing? I got crash while accessing Font.load() in NSAttributedString+Awesome line 21. Thats why I added Bundle.module there. |
It crashes if you try to use the pro font after loading it. The load will just fail silently if it can't find the pro fonts. The issue is that the pro files are in Bundle.main, while the regular font files are in Bundle.module. I believe you need to use Bundle.module only if the passed in bundle is nil, and it's AwesomeSPM. |
…and use the system defined `SWIFT_PACKAGE` setting rather than the custom `AwesomeSPM` setting.
I have just fixed this issue here: sarathsarah#1 |
Fix loading of AwesomePro fonts by letting the user pick the bundle
@lozhuf Merged your PR. and Thanks ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please remove the .swiftpm
folder from the commits please? Adding it to the .gitignorefile
would be best please
Adding .swiftpm to .gitignore will create issue isn't it? |
Moved Assets inside classes to work with Package.
Conflicts: .gitignore
Added Swift package support tested in Same project as well.